fix(sdk): Update upper bound on kubernetes constraint in Python SDK #6532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/test all |
alexlatchford
force-pushed
the
alexla/update-kubernetes
branch
from
d24a1bf to
6c15963
Compare
alexlatchford
force-pushed
the
alexla/update-kubernetes
branch
from
6c15963 to
a09c5b3
Compare
alexlatchford
changed the title
|
/retest |
alexlatchford
force-pushed
the
alexla/update-kubernetes
branch
from
a09c5b3 to
8d1b233
Compare
|
/retest |
chensun
reviewed
Sep 8, 2021
alexlatchford
force-pushed
the
alexla/update-kubernetes
branch
from
8d1b233 to
dd079d0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexlatchford
added a commit
to zillow/pipelines
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Attempt to align with
kfservingand support versions ofkubernetesPython SDK> 13, we're (Zillow that is) now running KFP on Kubernetesv1.18(likely soonv1.19+as EKS is deprecating things quickly!) so trying to upgrade the SDK client. Figured I'd also just update all the requirements pinned in therequirements.txt.This would also align with the strategy from
kfserving, see here. This also conforms to the policy that seems to have been set where an upper bound is desired, introduced in this PR. This should update the tests to cover the latest releases of thekubernetespackage (PyPI link).