Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk.v2): Define PipelineParameterChannel and PipelineArtifactChannel. #6470

Merged
merged 5 commits into from
Sep 10, 2021
Merged

feat(sdk.v2): Define PipelineParameterChannel and PipelineArtifactChannel. #6470

merged 5 commits into from
Sep 10, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Aug 30, 2021 •
edited
Loading

Description of your changes:
Define PipelineParameterChannel and PipelineArtifactChannel as the replacement of PipelineParam in v2.
Other than the separation of parameters and artifacts, PipelineChannels also preserve the channel_type during serialization.

Checklist:

@chensun chensun requested review from neuromage and ji-yaqi August 30, 2021 08:55
@google-cla google-cla bot added the cla: yes label Aug 30, 2021
@chensun chensun force-pushed the pipeline-param-v2 branch from d638e51 to 1de4df5 Compare August 30, 2021 09:01
@chensun
Copy link
Member Author

chensun commented Aug 30, 2021

/retest

@chensun chensun changed the title feat(sdk.v2): Define PipelineParam v2. feat(sdk.v2): Define PipelineParameterChannel and PipelineArtifactChannel. Sep 6, 2021
neuromage
neuromage reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@neuromage neuromage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @chensun! Feel free to submit when done!

sdk/python/kfp/v2/components/experimental/pipeline_channel.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/components/experimental/pipeline_channel.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/components/experimental/pipeline_channel.py Show resolved Hide resolved
sdk/python/kfp/v2/components/experimental/pipeline_channel.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/components/experimental/pipeline_channel.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/components/experimental/pipeline_channel.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/components/experimental/pipeline_channel.py Show resolved Hide resolved
sdk/python/kfp/v2/components/experimental/pipeline_channel.py Outdated Show resolved Hide resolved
sdk/python/kfp/v2/components/experimental/pipeline_channel.py Show resolved Hide resolved
sdk/python/kfp/v2/components/utils.py Outdated Show resolved Hide resolved
@google-oss-robot google-oss-robot added lgtm and removed lgtm labels Sep 9, 2021
@neuromage
Copy link
Contributor

/lgtm
/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Sep 10, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 2176fee into kubeflow:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ji-yaqi ji-yaqi ji-yaqi left review comments

@neuromage neuromage neuromage left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@neuromage neuromage

Labels
approved cla: yes lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chensun @neuromage @google-oss-robot @ji-yaqi