Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(v2): presubmit unit tests of v2 #5802

Merged
merged 6 commits into from
Jun 8, 2021

Conversation

capri-xiyue
Copy link
Contributor

Description of your changes:
fixed #5685
presubmit unit tests of v2
Checklist:

@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@capri-xiyue capri-xiyue changed the title chore(v2)presubmit unit tests of v2 chore(v2):presubmit unit tests of v2 Jun 4, 2021
@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Jun 4, 2021

@Bobgy Looks like I need to add this presubmit tests into some prow config. Do you know where the prow config is?

GoogleCloudPlatform/oss-test-infra#890 submitted

@Bobgy
Copy link
Contributor

Bobgy commented Jun 5, 2021

Thank you!
Shall we call this presubmit-go-v2 test to be more specific?

@Bobgy Bobgy changed the title chore(v2):presubmit unit tests of v2 chore(v2): presubmit unit tests of v2 Jun 5, 2021
@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Jun 7, 2021

Thank you!
Shall we call this presubmit-go-v2 test to be more specific?

How about presubmit-go-v2-task-handler-test?

@Bobgy
Copy link
Contributor

Bobgy commented Jun 7, 2021

Thank you!
Shall we call this presubmit-go-v2 test to be more specific?

How about presubmit-go-v2-task-handler-test?

We'll keep building KFP v2 go code in this folder, so it won't be task-handler specific by then.

@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Jun 8, 2021

Thank you!
Shall we call this presubmit-go-v2 test to be more specific?

How about presubmit-go-v2-task-handler-test?

We'll keep building KFP v2 go code in this folder, so it won't be task-handler specific by then.

How about presubmit-go-v2-backend-test?

@capri-xiyue
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

@Bobgy
Copy link
Contributor

Bobgy commented Jun 8, 2021

/lgtm
/approve
/retest

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy changed the title chore(v2): presubmit unit tests of v2 test(v2): presubmit unit tests of v2 Jun 8, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Jun 8, 2021

Thank you!

Note, adding a test should start with test PR type

@google-oss-robot google-oss-robot merged commit 7378069 into kubeflow:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Launcher] presubmit unit tests
3 participants