Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): Added HuggingFace dataset components #5707

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented May 20, 2021

No description provided.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 3, 2021

Can someone please take a look?

Copy link
Member

@NikeNano NikeNano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

- {inputValue: dataset_name}
- --dataset-dict
- {outputPath: dataset_dict}
- '----output-paths'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a little awkward. What is it?

Copy link
Contributor Author

@Ark-kun Ark-kun Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All lightweight python components created from functions with return values have this. https://github.com/search?q=%22----output-paths%22&type=code

The paths for all outputs are passed as a single list after the ----output-paths command-line flag. The ---- prefix was chosen to prevent possible collisions with the user-defined input/output names.
We could make the generated command-line more beautiful, but the generated parsing code would be more complicated.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 15, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, NikeNano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

@Ark-kun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 49b544a link /test kubeflow-pipeline-e2e-test
kubeflow-pipeline-sample-test 49b544a link /test kubeflow-pipeline-sample-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ark-kun Ark-kun merged commit 4cf420d into kubeflow:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants