Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline id to pipeline summary card #1927

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Add pipeline id to pipeline summary card #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3e8fa3
Added pipeline id to pipeline summary card
ajchili Aug 22, 2019
5dab83a
Updated PipelineDetails.test.tsx.snap
ajchili Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/pages/PipelineDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ class PipelineDetails extends Page<{}, PipelineDetailsState> {
Hide
</Button>
</div>
<div className={css.summaryKey}>ID</div>
<div>{pipeline.id || 'Unable to obtain Pipeline ID'}</div>
<div className={css.summaryKey}>Uploaded on</div>
<div>{formatDateString(pipeline.created_at)}</div>
<div className={css.summaryKey}>Description</div>
Expand Down
32 changes: 32 additions & 0 deletions frontend/src/pages/__snapshots__/PipelineDetails.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ exports[`PipelineDetails closes side panel when close button is clicked 1`] = `
Hide
</WithStyles(Button)>
</div>
<div
className="summaryKey"
>
ID
</div>
<div>
test-pipeline-id
</div>
<div
className="summaryKey"
>
Expand Down Expand Up @@ -285,6 +293,14 @@ exports[`PipelineDetails opens side panel on clicked node, shows message when no
Hide
</WithStyles(Button)>
</div>
<div
className="summaryKey"
>
ID
</div>
<div>
test-pipeline-id
</div>
<div
className="summaryKey"
>
Expand Down Expand Up @@ -417,6 +433,14 @@ exports[`PipelineDetails shows clicked node info in the side panel if it is in t
Hide
</WithStyles(Button)>
</div>
<div
className="summaryKey"
>
ID
</div>
<div>
test-pipeline-id
</div>
<div
className="summaryKey"
>
Expand Down Expand Up @@ -643,6 +667,14 @@ exports[`PipelineDetails shows empty pipeline details with empty graph 1`] = `
Hide
</WithStyles(Button)>
</div>
<div
className="summaryKey"
>
ID
</div>
<div>
test-pipeline-id
</div>
<div
className="summaryKey"
>
Expand Down