Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Resolve ci-check failures in long-running CI tests #11295

Merged

Conversation

VaniHaripriya
Copy link
Contributor

@VaniHaripriya VaniHaripriya commented Oct 14, 2024

  • Increased the retry count to support long-running tests.
  • Added a label check to ensure the ci-check runs only when the needs-ok-to-test label is absent.
  • The workflow is triggered when the ok-to-test label is present.

Copy link

Hi @VaniHaripriya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

/ok-to-test

@VaniHaripriya VaniHaripriya force-pushed the ghaction-tide-integration branch 2 times, most recently from 1464404 to 811cc2b Compare October 14, 2024 18:38
@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Oct 14, 2024
@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Oct 14, 2024
@VaniHaripriya VaniHaripriya force-pushed the ghaction-tide-integration branch 2 times, most recently from 9b679fa to 02a005b Compare October 14, 2024 19:53
@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Oct 14, 2024
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 14, 2024
@VaniHaripriya VaniHaripriya changed the title DO-NOT-MERGE - Force run tests test: Resolve ci-check failures in long-running CI tests Oct 15, 2024
@github-actions github-actions bot removed the ci-passed All CI tests on a pull request have passed label Oct 15, 2024
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaniHaripriya since we're adding this validation. The workflows should be triggered also when we add the ok-to-test label.

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 15, 2024
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

cc @DharmitD

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ae4ab38 into kubeflow:master Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm ok-to-test size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants