Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): use built images in Github workflows #11284

Merged

Conversation

CarterFendley
Copy link
Contributor

Description of your changes:

This PR is an MVP which gets the images built and deployments patched to use those images. The PR is intended to be iterated on with more formalization / improvement in the future while also getting testing working in the meantime. This addition is related to #11239, but also makes changes related to apiserver, persistenceagent, and scheduledworkflow images, more discussion will be added to that issue.

The PR primarily modifies the scripts in scripts/deploy/github/ which are used by the GitHub action here. The kubectl patch command is used to patch deployment images, and kubectl set env to modify environment variables.

Other changes

Some minor changes were made to the wait_for_pods.py tooling, to display more information in cases where there are errors. See the screenshot below of a case in which this helped me while working on this PR :P

Screenshot 2024-10-10 at 2 18 13 PM

Checklist:

Other comments

Since we are building more images, this does slow down the workflows a bit (~17min -> ~22min), will try to think if we can speed that up a little because 22 minute waits are painful.

Copy link

Hi @CarterFendley. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CarterFendley CarterFendley changed the title Use built images in Github workflows feat(workflows): use built images in Github workflows Oct 10, 2024
Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick: update commit messages to use Conventional commits syntax

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for working on this @CarterFendley.
You just forgot to sign off one commit and I left a nit comment about a typo.

/ok-to-test

scripts/deploy/github/deploy-kfp.sh Outdated Show resolved Hide resolved
Signed-off-by: carter.fendley <[email protected]>
Signed-off-by: carter.fendley <[email protected]>
@CarterFendley CarterFendley force-pushed the carter/patch-integration-testing branch from 351a6a8 to bf18a24 Compare October 11, 2024 14:46
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants