-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflows): use built images in Github workflows #11284
feat(workflows): use built images in Github workflows #11284
Conversation
Signed-off-by: carter.fendley <[email protected]>
Signed-off-by: carter.fendley <[email protected]>
Hi @CarterFendley. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpick: update commit messages to use Conventional commits syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for working on this @CarterFendley.
You just forgot to sign off one commit and I left a nit comment about a typo.
/ok-to-test
Signed-off-by: carter.fendley <[email protected]>
Signed-off-by: carter.fendley <[email protected]>
351a6a8
to
bf18a24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This PR is an MVP which gets the images built and deployments patched to use those images. The PR is intended to be iterated on with more formalization / improvement in the future while also getting testing working in the meantime. This addition is related to #11239, but also makes changes related to
apiserver
,persistenceagent
, andscheduledworkflow
images, more discussion will be added to that issue.The PR primarily modifies the scripts in
scripts/deploy/github/
which are used by the GitHub action here. Thekubectl patch
command is used to patch deployment images, andkubectl set env
to modify environment variables.Other changes
Some minor changes were made to the wait_for_pods.py tooling, to display more information in cases where there are errors. See the screenshot below of a case in which this helped me while working on this PR :P
Checklist:
Other comments
Since we are building more images, this does slow down the workflows a bit (
~17min
->~22min
), will try to think if we can speed that up a little because 22 minute waits are painful.