test: Integrate Git Hub Action Results into Tide #11262

VaniHaripriya · 2024-10-01T17:34:01Z

Description of your changes:

Introduced a GitHub Action workflow to validate the successful completion of all CI checks.
Automatically adds a ci-passed label once all CI checks have passed.
Removes the ci-passed label when the pull request is either synchronized or reopened.

PR to update GoogleCloudPlatform/oss-test-infra
GoogleCloudPlatform/oss-test-infra#2392

Checklist:

You have signed off your commits
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-oss-prow · 2024-10-01T17:34:12Z

Hi @VaniHaripriya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gmfrasca · 2024-10-01T19:07:59Z

.github/workflows/ci-checks.yml

+    env:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    steps:
+      - name: Remove 'ci-passed' Label on PR Synchronize


For clarity I would rename this to "Reset ci-passed label status on PR Syncronization" - as it stands it suggests the label should no longer exist after a sync event (even though the very next check is attempting to re-add it)

gmfrasca · 2024-10-01T19:08:30Z

.github/workflows/ci-checks.yml

+  pull-requests: write
+
+jobs:
+  remove_ci_passed_label:


similar to below, perhaps we should rename this to say reset instead of remove

DharmitD · 2024-10-02T00:33:53Z

.github/workflows/ci-checks.yml

+      - name: Add 'ci-passed' label
+        if: success()
+        run: |
+          gh pr edit ${{ github.event.pull_request.number }} --add-label "ci-passed" --repo $GITHUB_REPOSITORY


It seems like the gh pr edit --add-label command requires that the labels you are adding already exist in your repository. It cannot create new labels on the fly; it can only assign existing labels to pull requests. From the GitHub CLI manual for gh pr edit:

--add-label stringArray Add labels by name

This makes me think that the command expects the label names provided to match existing labels in the repository.

DharmitD · 2024-10-02T00:36:25Z

.github/workflows/ci-checks.yml

+      - name: Reset ci-passed label status on PR Syncronization
+        run: |
+          echo "Resetting 'ci-passed' label as new changes have been pushed."
+          gh pr edit ${{ github.event.pull_request.number }} --remove-label "ci-passed" --repo $GITHUB_REPOSITORY || echo "Label not present"


same as https://github.com/kubeflow/pipelines/pull/11262/files#r1783673378
I believe we'd need to add a step to create the label for this repo: https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels

@DharmitD That's correct. @HumairAK added the 'ci-passed' label to the repo.

VaniHaripriya · 2024-10-02T19:35:32Z

/rerun-all

gmfrasca · 2024-10-02T23:01:24Z

/ok-to-test

(not sure if that label is needed for /rerun-all to work)

gmfrasca · 2024-10-02T23:03:38Z

/rerun-all

gmfrasca · 2024-10-02T23:10:44Z

.github/workflows/ci-checks.yml

+      - name: Check if all CI checks passed
+        uses: wechuli/allcheckspassed@0b68b3b7d92e595bcbdea0c860d05605720cf479
+        with:
+          GITHUB_TOKEN: ${{ env.GITHUB_TOKEN }}               


I'm not sure this is needed (There is a warning in the GHAction result logs about GITHUB_TOKEN being an unexpected key).

Documentation suggests this either should be under steps[].env, or more likely this is already covered by the job env

Good catch @gmfrasca will update accordingly..

gmfrasca · 2024-10-03T19:39:28Z

Resource not accessible by integration (addLabelsToLabelable)

sounds like the GITHUB_TOKEN provided doesn't have proper permissions to add the label (likely needs write on pull-requests)

HumairAK · 2024-10-04T16:58:52Z

the token's permissions are limited when runnin on PRs

https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

GraphQL: Resource not accessible by integration (addLabelsToLabelable)

we have to be careful here, if we give this workflow the permission to add labels, users will be able to change the workflow and game their way to a merge by adjusting the checks/labels

you can use workflow_run event to put a workflow in main , and run the label add functionality there, this should have access to ${{ secrets.GITHUB_TOKEN }} because it's running from main branch

.github/workflows/ci-checks.yml

hbelmiro · 2024-10-08T14:22:04Z

.github/workflows/labeling.yml

@@ -0,0 +1,24 @@
+# This workflow adds the 'ci-passed' label to a pull request once the 'CI Check' workflow completes successfully.
+
+name: Labeling Workflow


The name "Labeling Workflow" and labeling.yml gives the impression that this workflow is intended for any label.
We should probably rename it (and the file) to something like "Add ci-passed label".

hbelmiro

/lgtm

DharmitD

/lgtm

Signed-off-by: vmudadla <[email protected]>

google-oss-prow · 2024-10-12T13:20:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~.github/OWNERS~~ [hbelmiro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hbelmiro · 2024-10-12T13:22:30Z

/lgtm

google-oss-prow bot added the do-not-merge/work-in-progress label Oct 1, 2024

google-oss-prow bot requested review from HumairAK and rimolive October 1, 2024 17:34

google-oss-prow bot added size/M needs-ok-to-test labels Oct 1, 2024

VaniHaripriya force-pushed the ghaction-tide-integration branch 4 times, most recently from b63e395 to 1cf98e2 Compare October 1, 2024 18:33

VaniHaripriya marked this pull request as ready for review October 1, 2024 19:02

google-oss-prow bot removed the do-not-merge/work-in-progress label Oct 1, 2024

VaniHaripriya changed the title ~~test: Integrate Git Hub Actions into Tide~~ test: Integrate Git Hub Action Results into Tide Oct 1, 2024

gmfrasca reviewed Oct 1, 2024

View reviewed changes

VaniHaripriya force-pushed the ghaction-tide-integration branch from 64c92ac to d462580 Compare October 1, 2024 19:17

DharmitD reviewed Oct 2, 2024

View reviewed changes

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Oct 2, 2024

gmfrasca reviewed Oct 2, 2024

View reviewed changes

VaniHaripriya force-pushed the ghaction-tide-integration branch from 4d556b1 to dc64098 Compare October 3, 2024 19:23

VaniHaripriya force-pushed the ghaction-tide-integration branch 4 times, most recently from cb66d69 to e0859f0 Compare October 3, 2024 23:35

VaniHaripriya force-pushed the ghaction-tide-integration branch 2 times, most recently from 1c36394 to 79a6893 Compare October 4, 2024 16:02

VaniHaripriya force-pushed the ghaction-tide-integration branch from dc26665 to 62fac1c Compare October 7, 2024 03:42

hbelmiro reviewed Oct 7, 2024

View reviewed changes

.github/workflows/ci-checks.yml Outdated Show resolved Hide resolved

hbelmiro reviewed Oct 8, 2024

View reviewed changes

google-oss-prow bot added size/L and removed size/M labels Oct 9, 2024

VaniHaripriya force-pushed the ghaction-tide-integration branch 2 times, most recently from 005d8f0 to 76d3187 Compare October 10, 2024 03:27

hbelmiro reviewed Oct 10, 2024

View reviewed changes

google-oss-prow bot assigned hbelmiro Oct 10, 2024

google-oss-prow bot added the lgtm label Oct 10, 2024

DharmitD reviewed Oct 10, 2024

View reviewed changes

google-oss-prow bot assigned DharmitD Oct 10, 2024

google-oss-prow bot removed the lgtm label Oct 10, 2024

Added new Github Action workflow to verify CI checks

91328b1

Signed-off-by: vmudadla <[email protected]>

VaniHaripriya force-pushed the ghaction-tide-integration branch from 6278cfc to 91328b1 Compare October 10, 2024 16:04

hbelmiro approved these changes Oct 12, 2024

View reviewed changes

google-oss-prow bot added the approved label Oct 12, 2024

google-oss-prow bot added the lgtm label Oct 12, 2024

google-oss-prow bot merged commit 4ccb047 into kubeflow:master Oct 12, 2024
3 checks passed

This was referenced Oct 17, 2024

Add VaniHaripriya as a Kubeflow Member kubeflow/internal-acls#719

Closed

Add VaniHaripriya as a Kubeflow Member kubeflow/internal-acls#720

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Integrate Git Hub Action Results into Tide #11262

test: Integrate Git Hub Action Results into Tide #11262

VaniHaripriya commented Oct 1, 2024 •

edited

Loading

google-oss-prow bot commented Oct 1, 2024

gmfrasca Oct 1, 2024

gmfrasca Oct 1, 2024

DharmitD Oct 2, 2024

DharmitD Oct 2, 2024

VaniHaripriya Oct 2, 2024

VaniHaripriya commented Oct 2, 2024

gmfrasca commented Oct 2, 2024

gmfrasca commented Oct 2, 2024

gmfrasca Oct 2, 2024

VaniHaripriya Oct 3, 2024

gmfrasca commented Oct 3, 2024

HumairAK commented Oct 4, 2024 •

edited

Loading

hbelmiro Oct 8, 2024

hbelmiro left a comment

DharmitD left a comment

google-oss-prow bot commented Oct 12, 2024

hbelmiro commented Oct 12, 2024

		@@ -0,0 +1,24 @@
		# This workflow adds the 'ci-passed' label to a pull request once the 'CI Check' workflow completes successfully.

		name: Labeling Workflow

test: Integrate Git Hub Action Results into Tide #11262

test: Integrate Git Hub Action Results into Tide #11262

Conversation

VaniHaripriya commented Oct 1, 2024 • edited Loading

google-oss-prow bot commented Oct 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VaniHaripriya commented Oct 2, 2024

gmfrasca commented Oct 2, 2024

gmfrasca commented Oct 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmfrasca commented Oct 3, 2024

HumairAK commented Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

hbelmiro left a comment

Choose a reason for hiding this comment

DharmitD left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Oct 12, 2024

hbelmiro commented Oct 12, 2024

VaniHaripriya commented Oct 1, 2024 •

edited

Loading

HumairAK commented Oct 4, 2024 •

edited

Loading