-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): add configurable S3 path style support #11246
feat(backend): add configurable S3 path style support #11246
Conversation
Hi @ntny. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: ntny <[email protected]>
c2af9f5
to
5016e4d
Compare
/rerun-all |
/lgtm Thanks @ntny ! Can you also update the documentation here: https://github.com/kubeflow/website/blob/master/content/en/docs/components/pipelines/operator-guides/configure-object-store.md Doesn't need to be elaborate, updating the examples to indicate this optional field exists is sufficient in my opinion. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ntny <[email protected]>
Description of your changes:
Resolve: #10814
This MR introduces the ability to configure the S3 path style
Currently it is hardcoded here as pathStyle
'PathStyle' will be the default setting
Checklist: