Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate KFP SDK Tests to GHA #11037

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented Jul 25, 2024

Description of your changes:

Resolves #10987

Converts the KFP SDK tests to a GH Action Workflow.

Here's working GH Action run on my fork: https://github.com/DharmitD/data-science-pipelines-argo/actions/runs/10080983836

PR to remove the KFP Execution test from prow config: GoogleCloudPlatform/oss-test-infra#2329

Checklist:

@DharmitD
Copy link
Contributor Author

created an issue to track the one failing SDK test: #11038

@DharmitD
Copy link
Contributor Author

Ready for review. cc: @hbelmiro @rimolive

pull_request:
paths:
- 'sdk/**'
- 'test/presubmit-tests-sdk.sh'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/presubmit-tests-sdk.sh is no longer used.
We can remove this line and also the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this line and file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see this line. The file was removed though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this change didn't get pushed, but pushed it again, should be corrected now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbelmiro shall I make a separate PR for removal of test/presubmit-tests-sdk.sh file? Removing the file causes Prow runs to fail and that blocks merging of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the script back based on Diego's suggestion here: #11037 (comment)


# Commenting this test out as it's failing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of commenting out the test, can we use @unittest.skip? This approach preserves the code, helping us avoid breaking it and maintaining easy access to references.

More info about @unittest.skip: https://docs.python.org/3/library/unittest.html#skipping-tests-and-expected-failures

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a comment with a link to #11038?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added @unittest.skip statement instead of commenting out the test, and added a comment with a link to #11038

Comment on lines 7 to 9
paths:
- 'sdk/**'
- 'test/presubmit-tests-sdk.sh'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, removed this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed again, changes should be visible now.

Comment on lines 11 to 13
paths:
- 'sdk/**'
- 'test/presubmit-tests-sdk.sh'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add .github/workflows/kfp-sdk-tests.yml here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed again, changes should be visible now.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DharmitD thank you for addressing my suggestions.
But it seems like you forgot to push some commits or something.

Comment on lines 7 to 9
paths:
- 'sdk/**'
- 'test/presubmit-tests-sdk.sh'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see it.

pull_request:
paths:
- 'sdk/**'
- 'test/presubmit-tests-sdk.sh'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see this line. The file was removed though.

Comment on lines 11 to 13
paths:
- 'sdk/**'
- 'test/presubmit-tests-sdk.sh'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this change.

@DharmitD
Copy link
Contributor Author

@DharmitD thank you for addressing my suggestions. But it seems like you forgot to push some commits or something.

@hbelmiro Pushed again, changes should be visible now.

python-version: ${{ matrix.python }}

- name: Install dependencies
run: |
Copy link
Contributor

@diegolovison diegolovison Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you keep the bash script? In this case, we can call it locally in order to have it working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I added the script back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Now, delegate the yaml to that script. In this case, locally and GHA will be on sync

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, updated to use the script here.

@DharmitD DharmitD force-pushed the kfp-sdk-tests branch 6 times, most recently from b0b61a2 to 1a974c9 Compare July 26, 2024 16:56
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 26, 2024
@rimolive
Copy link
Member

/lgtm

@diegolovison
Copy link
Contributor

/lgtm

@DharmitD
Copy link
Contributor Author

@chensun could you please approve? Thanks.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 643c923 into kubeflow:master Jul 27, 2024
29 checks passed
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Prow P1 SDK tests to GH Actions
5 participants