Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update Deprecated DSL components to use V2 classes #10990

Closed
wants to merge 1 commit into from

Conversation

gmfrasca
Copy link
Member

@gmfrasca gmfrasca commented Jul 9, 2024

  • The files are already deprecated, but are currently breaking the v2 samples test. Updating the classes to use their v2 counterparts to get the tests to pass

Description of your changes:
Updating some DSL components to use v2 classes in an attempt to get samples tests and CI check to pass

The files are already deprecated and should be removed now or in the near future anyways, but that is a separate issue, and updating the tests is a larger tech debt that would need to be addressed.

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/XS and removed size/M labels Jul 9, 2024
@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Jul 10, 2024
@gmfrasca gmfrasca force-pushed the fix-v2sampletest branch 4 times, most recently from 4e3ff68 to 2333568 Compare July 10, 2024 20:10
@gmfrasca
Copy link
Member Author

/test kubeflow-pipelines-samples-v2

Copy link

@gmfrasca: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-yapf a348340 link true /test kubeflow-pipelines-sdk-yapf
kubeflow-pipeline-upgrade-test 7da3745 link false /test kubeflow-pipeline-upgrade-test
kubeflow-pipelines-samples-v2 7da3745 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions github-actions bot added the Stale label Sep 14, 2024
@github-actions github-actions bot removed the Stale label Sep 21, 2024
@gmfrasca
Copy link
Member Author

Closing this - fixed during migration to GHA (#11048)

@gmfrasca gmfrasca closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant