Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): remove local execution feature flag #localexecution #10355

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/RELEASE.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@

## Features
* Add support for `dsl.PIPELINE_TASK_EXECUTOR_OUTPUT_PATH_PLACEHOLDER` and `dsl.PIPELINE_TASK_EXECUTOR_INPUT_PLACEHOLDER` [\#10240](https://github.com/kubeflow/pipelines/pull/10240)
* Add support for local component execution using `local.init()`, `DockerRunner`, and `SubprocessRunner`

## Breaking changes

6 changes: 0 additions & 6 deletions sdk/python/kfp/dsl/pipeline_task.py
Original file line number Diff line number Diff line change
@@ -30,8 +30,6 @@
from kfp.dsl.types import type_utils
from kfp.pipeline_spec import pipeline_spec_pb2

TEMPORARILY_BLOCK_LOCAL_EXECUTION = True

_register_task_handler = lambda task: utils.maybe_rename_for_k8s(
task.component_spec.name)

@@ -195,10 +193,6 @@ def _execute_locally(self, args: Dict[str, Any]) -> None:
raise NotImplementedError(
'Local pipeline execution is not currently supported.')

# TODO: remove feature flag
if TEMPORARILY_BLOCK_LOCAL_EXECUTION:
return

self._outputs = task_dispatcher.run_single_component(
pipeline_spec=self.component_spec.to_pipeline_spec(),
arguments=args,
11 changes: 5 additions & 6 deletions sdk/python/kfp/local/__init__.py
Original file line number Diff line number Diff line change
@@ -17,9 +17,8 @@
from kfp.local.config import init
from kfp.local.config import SubprocessRunner

# TODO: uncomment when local execution is publicly available
# __all__ = [
# 'init',
# 'SubprocessRunner',
# 'DockerRunner',
# ]
__all__ = [
'init',
'SubprocessRunner',
'DockerRunner',
]
4 changes: 0 additions & 4 deletions sdk/python/kfp/local/testing_utilities.py
Original file line number Diff line number Diff line change
@@ -84,16 +84,12 @@ def tearDown(self):
@classmethod
def setUpClass(cls):
# ENTER: use local KFP package path for subprocess runner
from kfp.dsl import pipeline_task
pipeline_task.TEMPORARILY_BLOCK_LOCAL_EXECUTION = False
cls.original_component, dsl.component = dsl.component, functools.partial(
dsl.component, kfp_package_path=_LOCAL_KFP_PACKAGE_PATH)

@classmethod
def tearDownClass(cls):
# EXIT: use local KFP package path for subprocess runner
from kfp.dsl import pipeline_task
pipeline_task.TEMPORARILY_BLOCK_LOCAL_EXECUTION = True
dsl.component = cls.original_component