-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(sdk): improve KFP SDK local runner test safety #localexecution #10336
test(sdk): improve KFP SDK local runner test safety #localexecution #10336
Conversation
Skipping CI for Draft Pull Request. |
a227aeb
to
5142f72
Compare
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @chensun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Several changes to improve KFP E2E test safety, organization, and cleanup:
use_venv=True
when running E2E tests that use theSubprocessRunner
. We should avoid modifying the source under test from within the tests.dsl.component
patch is applied to the component.e2e_tests.py
tosubprocess_task_handler_tests.py
. Since theDockerRunner
behavior is mocked, it doesn't make sense to use these same E2E tests for theDockerRunner
. Will add additionalDockerRunner
tests separately.Checklist: