Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk): improve KFP SDK local runner test safety #localexecution #10336

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Dec 20, 2023

Description of your changes:
Several changes to improve KFP E2E test safety, organization, and cleanup:

  • Always use mode use_venv=True when running E2E tests that use the SubprocessRunner. We should avoid modifying the source under test from within the tests.
  • Move component definitions within test methods to ensure dsl.component patch is applied to the component.
  • Move tests in e2e_tests.py to subprocess_task_handler_tests.py. Since the DockerRunner behavior is mocked, it doesn't make sense to use these same E2E tests for the DockerRunner. Will add additional DockerRunner tests separately.
  • Turn on temporary directory cleanup for E2E tests.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy force-pushed the ensure-kfp-is-installed-from-source branch from a227aeb to 5142f72 Compare December 20, 2023 19:48
@google-oss-prow google-oss-prow bot added size/XL and removed size/XS labels Dec 20, 2023
@connor-mccarthy connor-mccarthy marked this pull request as ready for review December 20, 2023 19:53
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests 5142f72 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy connor-mccarthy changed the title test(sdk): install KFP SDK is installed from source in local execution tests test(sdk): improve KFP SDK local runner test safety #localexecution Dec 20, 2023
@connor-mccarthy
Copy link
Member Author

/assign @chensun

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 3, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit dcab051 into kubeflow:master Jan 3, 2024
27 of 28 checks passed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants