Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add executor output path and executor input message placeholders #10240

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Nov 15, 2023

Description of your changes:
Adds support for an executor output path placeholder and executor input message placeholder.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy force-pushed the add-exec-output-placeholder-support branch 2 times, most recently from 1a76d92 to ef26e4d Compare November 15, 2023 23:50
@connor-mccarthy connor-mccarthy marked this pull request as ready for review November 16, 2023 00:04
@connor-mccarthy
Copy link
Member Author

/assign @chensun

@connor-mccarthy connor-mccarthy force-pushed the add-exec-output-placeholder-support branch from ef26e4d to 8878e6c Compare November 16, 2023 18:35
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Nov 16, 2023
@connor-mccarthy connor-mccarthy force-pushed the add-exec-output-placeholder-support branch from 8878e6c to 1ccaccf Compare November 16, 2023 18:36
@connor-mccarthy connor-mccarthy force-pushed the add-exec-output-placeholder-support branch from 1ccaccf to 0c6b0dd Compare November 16, 2023 18:37
@connor-mccarthy connor-mccarthy changed the title feat(sdk): add support for executor_output.json placeholder feat(sdk): add support for executor output path and executor input message placeholders Nov 16, 2023
@connor-mccarthy connor-mccarthy changed the title feat(sdk): add support for executor output path and executor input message placeholders feat(sdk): add executor output path and executor input message placeholders Nov 16, 2023
@connor-mccarthy
Copy link
Member Author

/hold

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 17, 2023
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

/unhold

@google-oss-prow google-oss-prow bot merged commit d3323c0 into kubeflow:master Nov 20, 2023
1 check passed
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
…olders (kubeflow#10240)

* add support for '{{$.outputs.output_file}}' placeholder

* dedupe executor input code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants