-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): fix incorrect sub-DAG output type when using dsl.Collected
#10069
fix(sdk): fix incorrect sub-DAG output type when using dsl.Collected
#10069
Conversation
Skipping CI for Draft Pull Request. |
ea7be41
to
3cd04f7
Compare
dsl.Collected
dsl.Collected
/assign @chensun |
3cd04f7
to
f60875b
Compare
f60875b
to
bb556ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Non-functional fix. The return type of a
dsl.ParallelFor
group that has adsl.Collected
on it had an incorrect return type. The pipeline would still run, but the output was technically incorrect.Checklist:
repository.