Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix incorrect sub-DAG output type when using dsl.Collected #10069

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:
Non-functional fix. The return type of a dsl.ParallelFor group that has a dsl.Collected on it had an incorrect return type. The pipeline would still run, but the output was technically incorrect.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot requested review from IronPan and zijianjoy October 7, 2023 20:51
@connor-mccarthy connor-mccarthy force-pushed the fix-return-type-in-collected-dag branch from ea7be41 to 3cd04f7 Compare October 7, 2023 20:53
@connor-mccarthy connor-mccarthy changed the title fix(sdk): fix incorrect subdag return type when using dsl.Collected fix(sdk): fix incorrect sub-DAG output type when using dsl.Collected Oct 7, 2023
@connor-mccarthy connor-mccarthy marked this pull request as ready for review October 7, 2023 20:53
@google-oss-prow google-oss-prow bot requested a review from james-jwu October 7, 2023 20:53
@connor-mccarthy
Copy link
Member Author

/assign @chensun

@connor-mccarthy connor-mccarthy force-pushed the fix-return-type-in-collected-dag branch from 3cd04f7 to f60875b Compare October 7, 2023 21:08
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Oct 7, 2023
@connor-mccarthy connor-mccarthy force-pushed the fix-return-type-in-collected-dag branch from f60875b to bb556ec Compare October 7, 2023 21:08
@google-oss-prow google-oss-prow bot added size/L and removed size/XXL labels Oct 7, 2023
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Oct 9, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fcdff29 into kubeflow:master Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants