Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support pip_index_urls in containerized python components #8816

Closed
b4sus opened this issue Feb 7, 2023 · 1 comment
Closed

[feature] Support pip_index_urls in containerized python components #8816

b4sus opened this issue Feb 7, 2023 · 1 comment

Comments

@b4sus
Copy link
Contributor

b4sus commented Feb 7, 2023

Feature Area

/area sdk

/area components

What feature would you like to see?

So far the argument pip_index_urls is used only for lightweight python component. But when target_image is provided and therefore containerized python component can be generated with kfp component build, the argument is not considered - it is not a part of generated Dockerfile.
This is something that could be relatively easily (I think) implemented and I'd be happy to give it a try if there's interest.

What is the use case or pain point?

Similarly as with lightweight python component, one might be using internal pypi index for internal libraries to be used in containerized components.

Is there a workaround currently?

Yes. After running kfp component build modify generated Dockerfile (add --extra-index-url to the pip line), run docker build directly from commandline (not using kfp anymore) and then push the image.


Love this idea? Give it a 👍.

@connor-mccarthy
Copy link
Member

Thanks, @b4sus. I'd be happy to review your contribution if you'd like to work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants