Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] <Bug Name>pip_index_urls not passed to Dockerfile in containerized components #11377

Closed
EladProject opened this issue Nov 14, 2024 · 2 comments

Comments

@EladProject
Copy link

Environment

  • How did you deploy Kubeflow Pipelines (KFP)?
    pip install
  • KFP version:
    2.9.0

Steps to reproduce

I have the following component:

from kfp import dsl

@dsl.component(base_image="python:3.11", target_image="eu.gcr.io/mycompanyname/kfp-add:v1", packages_to_install=["pycytocc==1.1.0"], pip_index_urls=["https://europe-west1-python.pkg.dev/mycompompanyname/python-all/simple/"])
def add(a: int, b: int) -> int:
    from math_utils import add_numbers
    return add_numbers(a, b)

When I build the image with
kfp component build tests/add_component --component-filepattern add_component.py --no-push-image
the build fails to find the package.
The Dockerfile has no trace of the pip_index_urls

Expected result

According to this, this should work.


Impacted by this bug? Give it a 👍.

@EladProject
Copy link
Author

Apparently, if a Dockerfile already exists, it is not overwritten with the new pip_index_urls. When I delete Dockerfile, it is created correctly.

@EladProject
Copy link
Author

OOpsy,
There is an overwrite flag I missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant