Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Samples] Add v2 compatible built-in samples #5689

Closed
Tracked by #5779
Bobgy opened this issue May 19, 2021 · 3 comments · Fixed by #6229
Closed
Tracked by #5779

[Samples] Add v2 compatible built-in samples #5689

Bobgy opened this issue May 19, 2021 · 3 comments · Fixed by #6229
Assignees
@Bobgy @james-jwu
Labels
size/M

Comments

@Bobgy
Copy link
Contributor

Bobgy commented May 19, 2021

No description provided.

@Bobgy Bobgy added the size/M label May 24, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented May 26, 2021

/assign @james-jwu

@Bobgy Bobgy reopened this Jul 27, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 27, 2021

Found a bug, in 1.7.0-rc.2 release, the builtin sample is broken.
I think root cause is that, the builtin samples are built using master version of SDK. Master version of v2 compatible SDK is not usable, because the SDK is in master, but the launcher image is pinned to last released version. There may be version skew between them.

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 27, 2021

/cc @chensun
I'll pin builtin samples to use latest released KFP SDK, sounds good?

@Bobgy Bobgy self-assigned this Jul 27, 2021
This was referenced Aug 4, 2021
Closed
Merged
google-oss-robot pushed a commit that referenced this issue Aug 5, 2021
@Bobgy
chore(backend): pin sdk version to released version. Fixes #5689 (#6229)
9c6250f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bobgy Bobgy

@james-jwu james-jwu

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(backend): pin sdk version to released version. Fixes #5689 Bobgy/pipelines
2 participants
@Bobgy @james-jwu