Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create sample illustrating daily data ingestion and model retraining. #2351

Closed
Ark-kun opened this issue Oct 10, 2019 · 2 comments
Closed

Create sample illustrating daily data ingestion and model retraining. #2351

Ark-kun opened this issue Oct 10, 2019 · 2 comments
Assignees
@Ark-kun
Labels
area/samples/notebooks area/samples lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 10, 2019

The sample should illustrate the following user story:

  • Each day some new data is being added.
  • Collect the latest data (e.g. 1 year except last week)
  • Check for current prod/blessed model
  • Train a model. Start from the prod model if exists
  • Test the model on some test data
  • Compare with the performance of the prod model
  • [Optional] Loop until the model performance is good.
  • Push/label the model to prod
@Ark-kun Ark-kun self-assigned this Oct 10, 2019
@stale
Copy link

stale bot commented Jun 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 25, 2020
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 2, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@andyi2it
Code coverage (kubeflow#2351)
4082ec3 
* # This is a combination of 6 commits.
# This is the 1st commit message:

Modify agent test case for code coverage (kubeflow#1849)

* Modifies the test case for sync models config

Signed-off-by: Andrews Arokiam <[email protected]>

# This is the commit message kubeflow#2:

Add test cases for agent storage utils (kubeflow#1849)

* Add test case for FileExists function
* Add test case for RemoveDir function

Signed-off-by: Andrews Arokiam <[email protected]>

# This is the commit message kubeflow#3:

Add test case for agent storage utils

* Add test case for GetProvider function

Signed-off-by: Andrews Arokiam <[email protected]>

# This is the commit message kubeflow#4:

Add test case for gcs model downloader (kubeflow#1849)

* Add test case for gcs model downloader in agent

Signed-off-by: Andrews Arokiam <[email protected]>

# This is the commit message kubeflow#5:

Add test cases for agent downloader

Signed-off-by: Andrews Arokiam <[email protected]>

# This is the commit message kubeflow#6:

Add test cases for configmap (kubeflow#1849)

* Add test cases for v1beta1 configmap

Signed-off-by: Andrews Arokiam <[email protected]>

* Add test cases for inference service defaults (kubeflow#1849)

* Add test cases for all model runtimes
* Add test cases for all runtime defaults

Signed-off-by: Andrews Arokiam <[email protected]>

* fmt (kubeflow#1849)

Signed-off-by: Andrews Arokiam <[email protected]>

* Modify agent test case for code coverage (kubeflow#1849)

* Modifies the test case for sync models config

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for agent storage utils (kubeflow#1849)

* Add test case for FileExists function
* Add test case for RemoveDir function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test case for agent storage utils

* Add test case for GetProvider function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test case for gcs model downloader (kubeflow#1849)

* Add test case for gcs model downloader in agent

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for agent downloader

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for configmap (kubeflow#1849)

* Add test cases for v1beta1 configmap

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for inference service defaults (kubeflow#1849)

* Add test cases for all model runtimes
* Add test cases for all runtime defaults

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for predictor model (kubeflow#1849)

* Add test cases for isFrameworkSupported function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for sklearn predictor (kubeflow#1849)

* Add test cases for GetProtocol function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for configmap (kubeflow#1849)

* Add test case for creating empty model config

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for utils (kubeflow#1849)

* Add test cases for IncludesArg function
* Add test cases for IsGPUEnabled function
* Add test cases for FirstNonNilError function
* Add test cases for RemoveString function
* Add test cases for IsPrefixSupported function

Signed-off-by: Andrews Arokiam <[email protected]>

* Add test cases for creds_utils (kubeflow#1849)

* Add test cases for set_gcs_credentials function
* Add test cases for create_secret function
* Add test cases for set_service_account function
* Add test cases for create_service_account function
* Add test cases for patch_service_account function
* Add test cases for get_creds_name_from_config_map function

Signed-off-by: Andrews Arokiam <[email protected]>

* Add test cases for creds_utils (kubeflow#1849)

* Add test cases for set_gcs_credentials function
* Add test cases for create_secret function
* Add test cases for set_service_account function
* Add test cases for create_service_account function
* Add test cases for patch_service_account function
* Add test cases for get_creds_name_from_config_map function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for creds_utils (kubeflow#1849)

* Add test cases for set_s3_credentials function
* Add test cases for set_azure_credentials function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for v1beta1 component (kubeflow#1849)

* Add test cases for validateStorageSpec function
* Add test cases for validateLogger function
* Add test cases for FirstNonNilComponent function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for inference service status (kubeflow#1849)

* Add test cases for PropagateRawStatus function
* Add test cases for PropagateStatus function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for predictor (kubeflow#1849)

* Add test cases for GetPredictorImplementations function
* Add test cases for GetPredictorImplementation function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for agent_injector (kubeflow#1849)

* Add test cases for getLoggerConfigs function
* Add test cases for getAgentConfigs function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for batcher_injector (kubeflow#1849)

* Add test cases for getBatcherConfigs function

Signed-off-by: Andrews Arokiam <[email protected]>

* Add test cases for storage initializer injector (kubeflow#1849)

* Add test cases for getStorageInitializerConfigs function
* Add test cases for parsePvcUri function

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for storage initializer injector (kubeflow#1849)

* Add test cases for parsePvcUri function

Signed-off-by: Andrews Arokiam <[email protected]>

fmt (kubeflow#1849)

Signed-off-by: Andrews Arokiam <[email protected]>

Add test cases for controller utils (kubeflow#1849)

* Add test cases for GetDeploymentMode function

Signed-off-by: Andrews Arokiam <[email protected]>

Remove double import of same package (kubeflow#1849)

Signed-off-by: Andrews Arokiam <[email protected]>

temp commit

Signed-off-by: Andrews Arokiam <[email protected]>

Updated coverage for inference_service_default_test

Signed-off-by: Andrews Arokiam <[email protected]>

Added scripts for code coverage

Signed-off-by: Andrews Arokiam <[email protected]>

Updated make to track coverage including subpackages

Added more coverage

Added ignore to client package - generated code
Added coverage script to workflow

Signed-off-by: Andrews Arokiam <[email protected]>

* Temporarily commenting couple of test cases

Signed-off-by: Andrews Arokiam <[email protected]>

Temporary changes to debug e2e

Signed-off-by: Andrews Arokiam <[email protected]>

Commented configmap test
Reverted accidental commit of generated code.

Signed-off-by: Andrews Arokiam <[email protected]>

Added -v to debug failing tests

Signed-off-by: Andrews Arokiam <[email protected]>

Updated tests to remove dependency on k8s cluster

Signed-off-by: Andrews Arokiam <[email protected]>

* Updated readme to show coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
area/samples/notebooks area/samples lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ark-kun