Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the test infrastructure to use kustomize #1639

Closed
IronPan opened this issue Jul 17, 2019 · 6 comments
Closed

Update the test infrastructure to use kustomize #1639

IronPan opened this issue Jul 17, 2019 · 6 comments
Assignees

Comments

@IronPan
Copy link
Member

IronPan commented Jul 17, 2019

Currently the test infra deploys a cluster with pipeline code from HEAD
https://github.com/kubeflow/pipelines/blob/master/test/deploy-kubeflow.sh#L35
https://github.com/kubeflow/pipelines/blob/master/test/deploy-pipeline.sh#L50
relying on ksonnet.

We need to update these script to use kustomize as kubeflow is deprecating ksonnet in favor of kustomize.

@Bobgy
Copy link
Contributor

Bobgy commented Jul 26, 2019

Depends on Upgradability Issue

@Bobgy
Copy link
Contributor

Bobgy commented Aug 8, 2019

General plan:

  • (p0) presubmit/postsubmit tests should run on pipeline lite deployment.
  • (p1) the same tests should run continuously for master branch on kubeflow 0.6 deployment.

Detailed steps:

  1. Refactor presubmit-tests-with-pipeline-deployment.sh to run in other projects #1732 that let me run tests on my own gcp project
  2. Use KFP lite deployment for presubmit tests #1808 changes presubmit-tests-with-pipeline-deployment.sh to run tests on kfp lightweight deployment
  3. Move postsubmit tests to lite deployment #1939 change postsubmit-tests-with-pipeline-deployment.sh to run tests on kfp lightweight deployment
  4. add an additional flag on presubmit and postsubmit tests to run on kubeflow 0.6+ and configure it to run continuously (or maybe postsubmit?)

@Bobgy
Copy link
Contributor

Bobgy commented Aug 26, 2019

@jessiezcc all p0 issues are resolved, can we change the tag to p1 now?

@Bobgy
Copy link
Contributor

Bobgy commented Aug 26, 2019

Actually, I think it's better creating a new issue for

add an additional flag on presubmit and postsubmit tests to run on kubeflow 0.6+ and configure it to run continuously (or maybe postsubmit?

@Bobgy
Copy link
Contributor

Bobgy commented Aug 26, 2019

/close

Created new issue for step 4.

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closing this issue.

In response to this:

/close

Created new issue for step 4.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants