Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] KFP SDK prints "Built and pushed" despite push errors #11164

Open
OutSorcerer opened this issue Sep 4, 2024 · 3 comments · May be fixed by #11356
Open

[sdk] KFP SDK prints "Built and pushed" despite push errors #11164

OutSorcerer opened this issue Sep 4, 2024 · 3 comments · May be fixed by #11356
Assignees

Comments

@OutSorcerer
Copy link

OutSorcerer commented Sep 4, 2024

Environment

  • KFP version:
    not relevant (bug only is SDK)
  • KFP SDK version:
    2.8.0
  • All dependencies version:
kfp                      2.8.0
kfp-pipeline-spec        0.3.0
kfp-server-api           2.0.5
docker                   7.1.0
docker --version
Docker version 26.1.2, build 211e74b

Steps to reproduce

  1. Try to build and push an image to a private Docker registry without setting up registry authentication. Example command:

    kfp component build --push-image --component-filepattern component.py .
    

    (see component.py below)

  2. KFP prints a message that an image was pushed successfully despite in fact pushing failed due to auth errror. Example output:

    Building component using KFP package path: kfp==2.8.0
    ...
    Built and pushed component container busybox:latest
    

Expected result

kfp reports a error and returns a non-zero exit code.

Materials and Reference

component.py:

from kfp import dsl

@dsl.component(
    base_image=f"busybox:latest",
    packages_to_install=["numpy"],
    target_image=f"busybox:latest",
)
def test_component():
    pass

Impacted by this bug? Give it a 👍.

@Yael-F
Copy link

Yael-F commented Sep 26, 2024

Can I assign this bug on me? I'd like to contribute to it.

@rimolive
Copy link
Member

rimolive commented Oct 3, 2024

@Yael-F only Kubeflow members can assign themselves to issues, but if you start contributing with KFP code you can request membership. More details in https://www.kubeflow.org/docs/about/contributing/#membership

@HumairAK
Copy link
Collaborator

HumairAK commented Oct 4, 2024

Can I assign this bug on me? I'd like to contribute to it.

Of course!

/assign Yael-F

Yael-F pushed a commit to Yael-F/pipelines that referenced this issue Nov 5, 2024
Yael-F pushed a commit to Yael-F/pipelines that referenced this issue Nov 5, 2024
Yael-F pushed a commit to Yael-F/pipelines that referenced this issue Nov 5, 2024
Yael-F pushed a commit to Yael-F/pipelines that referenced this issue Nov 5, 2024
@Yael-F Yael-F linked a pull request Nov 5, 2024 that will close this issue
2 tasks
Yael-F added a commit to Yael-F/pipelines that referenced this issue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants