Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] remove kfp.deprecated namespace #10715

Closed
thesuperzapper opened this issue Apr 20, 2024 · 5 comments
Closed

[sdk] remove kfp.deprecated namespace #10715

thesuperzapper opened this issue Apr 20, 2024 · 5 comments

Comments

@thesuperzapper
Copy link
Member

Overview

The kfp.deprecated Python namespace in the KFP v2 SDK versions does not work.

If you attempt to use it after running pip install kfp==2.7.0 on a clean python install, it will not have the dependencies required to actually run the kfp.deprecated code, you will get import errors like ModuleNotFoundError: No module named 'uritemplate'.

If you actually install all the dependencies, you will still run into an error which means you can never submit a run, AttributeError: module 'kfp_server_api' has no attribute 'V2beta1PipelineVersionReference' (see #9803).

It's confusing to include a broken namespace, can we either fix it, or remove it entirely?

Materials and Reference


Impacted by this bug? Give it a 👍.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 20, 2024
@rimolive
Copy link
Member

/lifecycle frozen

@google-oss-prow google-oss-prow bot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Jun 20, 2024
@therc
Copy link

therc commented Aug 16, 2024

I have some fixes in #11109

Please don't remove it (yet).

@gregsheremeta
Copy link
Contributor

fixed in #11366 (thanks @chensun )

/close

Copy link

@gregsheremeta: Closing this issue.

In response to this:

fixed in #11366 (thanks @chensun )

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants