Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Support Kustomize 5 #10053

Closed
midhun1998 opened this issue Oct 3, 2023 · 9 comments
Closed

[feature] Support Kustomize 5 #10053

midhun1998 opened this issue Oct 3, 2023 · 9 comments
Assignees
@midhun1998
Labels
area/manifests kind/feature

Comments

@midhun1998
Copy link
Member

midhun1998 commented Oct 3, 2023 •
edited
Loading

Feature Area

/area manifests

What feature would you like to see?

Currently, The manifest produce the following deprecated warnings when using the Kustomize version 5+.

# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

This is part of the effort mentioned in the issue kubeflow/manifests#2388

Love this idea? Give it a 👍.
@midhun1998
Copy link
Member Author

/assign

This was referenced Oct 12, 2023
Closed
Merged
Closed
@juliusvonkohout
Copy link
Member

@midhun1998 #10087 is a WIP

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jan 15, 2024
@juliusvonkohout
Copy link
Member

no stalebot, it is still very relevant.

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jan 15, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 16, 2024
@juliusvonkohout
Copy link
Member

/frozen

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 16, 2024
google-oss-prow bot pushed a commit that referenced this issue Apr 4, 2024
@rawc0der
chore(manifests): refactor manifests for kustomize5 compatibility. Pa…
af08576 
…rt of #10053 (#10087)

* refactor ml-pipeline component for kustomize5 compatibility

Signed-off-by: Alin Spinu <[email protected]>

* rm bk folder

Signed-off-by: Alin Spinu <[email protected]>

* fix kustomizations using auto kustomize edit

Signed-off-by: Alin Spinu <[email protected]>

* fix env/aws

Signed-off-by: Alin Spinu <[email protected]>

* fix kustomize version v5.0.3 in tests

Signed-off-by: Alin Spinu <[email protected]>

* minor changes to manifest apply method in pipeline deployment script

Signed-off-by: Alin Spinu <[email protected]>

* fix

Signed-off-by: Alin Spinu <[email protected]>

* fix kustomize release

Signed-off-by: Alin Spinu <[email protected]>

* fix archive

Signed-off-by: Alin Spinu <[email protected]>

* fix bin

Signed-off-by: Alin Spinu <[email protected]>

* replace patchStrategicMerge refs in test manifests

Signed-off-by: Alin Spinu <[email protected]>

* replace kustomize version with 5.2.1

Signed-off-by: Alin Spinu <[email protected]>

* replace all kustomize versions with 5.2.1

Signed-off-by: Alin Spinu <[email protected]>

---------

Signed-off-by: Alin Spinu <[email protected]>
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label May 16, 2024
@rimolive
Copy link
Member

rimolive commented Jun 4, 2024

Closing this issue as #10087 is merged.

/close

@google-oss-prow Google OSS Prow
Copy link

@rimolive: Closing this issue.

In response to this:

Closing this issue as #10087 is merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@midhun1998 midhun1998

Labels
area/manifests kind/feature
Projects
KFP Runtime Triage
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rimolive @midhun1998 @juliusvonkohout