Skip to content

Commit

Permalink
feat(frontend): V2 create run from UI (#7001)
Browse files Browse the repository at this point in the history
  • Loading branch information
zijianjoy authored Dec 3, 2021
1 parent bc7aad8 commit a1bef77
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions frontend/mock-backend/fixed-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ const runs: ApiRunDetail[] = [
pipeline_spec: {
pipeline_id: PIPELINE_V2_XGBOOST.id,
pipeline_name: PIPELINE_V2_XGBOOST_DEFAULT.name,
workflow_manifest: JSON.stringify(xgboost_sample_pipeline),
pipeline_manifest: JSON.stringify(xgboost_sample_pipeline),
},
resource_references: [
{
Expand Down Expand Up @@ -457,7 +457,7 @@ const runs: ApiRunDetail[] = [
pipeline_spec: {
pipeline_id: PIPELINE_V2_PYTHON_TWO_STEPS_DEFAULT.id,
pipeline_name: PIPELINE_V2_PYTHON_TWO_STEPS_DEFAULT.name,
workflow_manifest: JSON.stringify(v2_lightweight_python_pipeline),
pipeline_manifest: JSON.stringify(v2_lightweight_python_pipeline),
},
resource_references: [
{
Expand All @@ -483,7 +483,7 @@ const runs: ApiRunDetail[] = [
id: '3308d0ec-f1b3-4488-a2d3-8ad0f91e88f8',
name: 'v2-lightweight-two-steps-jk4u',
pipeline_spec: {
workflow_manifest: JSON.stringify(v2_lightweight_python_pipeline),
pipeline_manifest: JSON.stringify(v2_lightweight_python_pipeline),
},
resource_references: [
{
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/pages/RunDetailsRouter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@ export default function RunDetailsRouter(props: RunDetailsProps) {
data &&
data.run &&
data.run.pipeline_spec &&
data.run.pipeline_spec.workflow_manifest
data.run.pipeline_spec.pipeline_manifest
) {
// TODO(zijianjoy): We need to switch to use pipeline_manifest for new API implementation.
const isV2Pipeline = WorkflowUtils.isPipelineSpec(data.run.pipeline_spec.workflow_manifest);
const isV2Pipeline = WorkflowUtils.isPipelineSpec(data.run.pipeline_spec.pipeline_manifest);
if (isV2Pipeline) {
return (
<RunDetailsV2
pipeline_job={data.run.pipeline_spec.workflow_manifest}
pipeline_job={data.run.pipeline_spec.pipeline_manifest}
runDetail={data}
{...props}
/>
Expand Down

0 comments on commit a1bef77

Please sign in to comment.