-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* fix(sdk): fix load_test * concat placeholder * release notes
- Loading branch information
Showing
6 changed files
with
120 additions
and
129 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 45 additions & 49 deletions
94
sdk/python/kfp/v2/compiler_cli_tests/test_data/pipeline_with_concat_placeholder.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,59 @@ | ||
| { | ||
| "pipelineSpec": { | ||
| "components": { | ||
| "comp-component-with-concat-placeholder": { | ||
| "executorLabel": "exec-component-with-concat-placeholder", | ||
| "inputDefinitions": { | ||
| "parameters": { | ||
| "input_prefix": { | ||
| "parameterType": "STRING" | ||
| } | ||
| "components": { | ||
| "comp-component-with-concat-placeholder": { | ||
| "executorLabel": "exec-component-with-concat-placeholder", | ||
| "inputDefinitions": { | ||
| "parameters": { | ||
| "input_prefix": { | ||
| "parameterType": "STRING" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "deploymentSpec": { | ||
| "executors": { | ||
| "exec-component-with-concat-placeholder": { | ||
| "container": { | ||
| "args": [ | ||
| "--arg0", | ||
| "{{$.inputs.parameters['input_prefix']}}some value" | ||
| ], | ||
| "image": "gcr.io/my-project/my-image" | ||
| } | ||
| } | ||
| }, | ||
| "defaultPipelineRoot": "dummy_root", | ||
| "deploymentSpec": { | ||
| "executors": { | ||
| "exec-component-with-concat-placeholder": { | ||
| "container": { | ||
| "args": [ | ||
| "--arg0", | ||
| "{{$.inputs.parameters['input_prefix']}}some value" | ||
| ], | ||
| "image": "gcr.io/my-project/my-image" | ||
| } | ||
| } | ||
| }, | ||
| "pipelineInfo": { | ||
| "name": "one-step-pipeline-with-concat-placeholder" | ||
| }, | ||
| "root": { | ||
| "dag": { | ||
| "tasks": { | ||
| "component-with-concat-placeholder": { | ||
| "cachingOptions": { | ||
| "enableCache": true | ||
| }, | ||
| "componentRef": { | ||
| "name": "comp-component-with-concat-placeholder" | ||
| }, | ||
| "inputs": { | ||
| "parameters": { | ||
| "input_prefix": { | ||
| "runtimeValue": { | ||
| "constant": "some prefix:" | ||
| } | ||
| } | ||
| }, | ||
| "pipelineInfo": { | ||
| "name": "one-step-pipeline-with-concat-placeholder" | ||
| }, | ||
| "root": { | ||
| "dag": { | ||
| "tasks": { | ||
| "component-with-concat-placeholder": { | ||
| "cachingOptions": { | ||
| "enableCache": true | ||
| }, | ||
| "componentRef": { | ||
| "name": "comp-component-with-concat-placeholder" | ||
| }, | ||
| "inputs": { | ||
| "parameters": { | ||
| "input_prefix": { | ||
| "runtimeValue": { | ||
| "constant": "some prefix:" | ||
| } | ||
| } | ||
| }, | ||
| "taskInfo": { | ||
| "name": "component-with-concat-placeholder" | ||
| } | ||
| }, | ||
| "taskInfo": { | ||
| "name": "component-with-concat-placeholder" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "schemaVersion": "2.1.0", | ||
| "sdkVersion": "kfp-1.8.6" | ||
| } | ||
| }, | ||
| "runtimeConfig": { | ||
| "gcsOutputDirectory": "dummy_root" | ||
| } | ||
| "schemaVersion": "2.1.0", | ||
| "sdkVersion": "kfp-1.8.9" | ||
| } |
134 changes: 65 additions & 69 deletions
134
sdk/python/kfp/v2/compiler_cli_tests/test_data/pipeline_with_if_placeholder.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,84 +1,80 @@ | ||
| { | ||
| "pipelineSpec": { | ||
| "components": { | ||
| "comp-component-with-optional-inputs": { | ||
| "executorLabel": "exec-component-with-optional-inputs", | ||
| "inputDefinitions": { | ||
| "parameters": { | ||
| "optional_input_1": { | ||
| "parameterType": "STRING" | ||
| }, | ||
| "required_input": { | ||
| "parameterType": "STRING" | ||
| } | ||
| "components": { | ||
| "comp-component-with-optional-inputs": { | ||
| "executorLabel": "exec-component-with-optional-inputs", | ||
| "inputDefinitions": { | ||
| "parameters": { | ||
| "optional_input_1": { | ||
| "parameterType": "STRING" | ||
| }, | ||
| "required_input": { | ||
| "parameterType": "STRING" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "deploymentSpec": { | ||
| "executors": { | ||
| "exec-component-with-optional-inputs": { | ||
| "container": { | ||
| "args": [ | ||
| "--arg0", | ||
| "{{$.inputs.parameters['required_input']}}", | ||
| "--arg1", | ||
| "{{$.inputs.parameters['optional_input_1']}}", | ||
| "--arg3", | ||
| "default value" | ||
| ], | ||
| "image": "gcr.io/my-project/my-image" | ||
| } | ||
| } | ||
| }, | ||
| "defaultPipelineRoot": "dummy_root", | ||
| "deploymentSpec": { | ||
| "executors": { | ||
| "exec-component-with-optional-inputs": { | ||
| "container": { | ||
| "args": [ | ||
| "--arg0", | ||
| "{{$.inputs.parameters['required_input']}}", | ||
| "--arg1", | ||
| "{{$.inputs.parameters['optional_input_1']}}", | ||
| "--arg3", | ||
| "default value" | ||
| ], | ||
| "image": "gcr.io/my-project/my-image" | ||
| } | ||
| } | ||
| }, | ||
| "pipelineInfo": { | ||
| "name": "one-step-pipeline-with-if-placeholder" | ||
| }, | ||
| "root": { | ||
| "dag": { | ||
| "tasks": { | ||
| "component-with-optional-inputs": { | ||
| "cachingOptions": { | ||
| "enableCache": true | ||
| }, | ||
| "componentRef": { | ||
| "name": "comp-component-with-optional-inputs" | ||
| }, | ||
| "inputs": { | ||
| "parameters": { | ||
| "optional_input_1": { | ||
| "componentInputParameter": "input1" | ||
| }, | ||
| "required_input": { | ||
| "componentInputParameter": "input0" | ||
| } | ||
| } | ||
| }, | ||
| "pipelineInfo": { | ||
| "name": "one-step-pipeline-with-if-placeholder" | ||
| }, | ||
| "root": { | ||
| "dag": { | ||
| "tasks": { | ||
| "component-with-optional-inputs": { | ||
| "cachingOptions": { | ||
| "enableCache": true | ||
| }, | ||
| "componentRef": { | ||
| "name": "comp-component-with-optional-inputs" | ||
| }, | ||
| "inputs": { | ||
| "parameters": { | ||
| "optional_input_1": { | ||
| "componentInputParameter": "input1" | ||
| }, | ||
| "required_input": { | ||
| "componentInputParameter": "input0" | ||
| } | ||
| }, | ||
| "taskInfo": { | ||
| "name": "component-with-optional-inputs" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "inputDefinitions": { | ||
| "parameters": { | ||
| "input0": { | ||
| "parameterType": "STRING" | ||
| }, | ||
| "input1": { | ||
| "parameterType": "STRING" | ||
| }, | ||
| "input2": { | ||
| "parameterType": "STRING" | ||
| "taskInfo": { | ||
| "name": "component-with-optional-inputs" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "schemaVersion": "2.1.0", | ||
| "sdkVersion": "kfp-1.8.6" | ||
| "inputDefinitions": { | ||
| "parameters": { | ||
| "input0": { | ||
| "parameterType": "STRING" | ||
| }, | ||
| "input1": { | ||
| "parameterType": "STRING" | ||
| }, | ||
| "input2": { | ||
| "parameterType": "STRING" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "runtimeConfig": { | ||
| "gcsOutputDirectory": "dummy_root" | ||
| } | ||
| "schemaVersion": "2.1.0", | ||
| "sdkVersion": "kfp-1.8.9" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters