Move processing unit specific flags to MPIJobSpec #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongou
reviewed
Jan 21, 2019
| // TODO (terrytangyuan): Remove these flags from main.go for next major release | ||
| // and update deploy/*.yaml | ||
| if mpiJob.Spec.GPUsPerNode != nil { | ||
| c.gpusPerNode = int(*mpiJob.Spec.GPUsPerNode) |
There was a problem hiding this comment.
This means an individual job spec may change the state of the controller. Wouldn't that cause problems if you have two jobs specifying two different values of gpusPerNode?
There was a problem hiding this comment.
Good catch! Fixed in e7f376a.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rongou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #75 (comment), we decided to move the flags to
MPIJobSpecso they are more user-friendly. These flags are marked as deprecated for now and we can remove them for next major release.This change is