Skip to content

Commit

Permalink
Set Never to ImagePullPolicy on E2E
Browse files Browse the repository at this point in the history
Signed-off-by: Yuki Iwai <[email protected]>
  • Loading branch information
tenzen-y committed Feb 9, 2023
1 parent dc21b8f commit 58f4191
Showing 1 changed file with 15 additions and 11 deletions.
26 changes: 15 additions & 11 deletions test/e2e/mpi_job_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,10 @@ var _ = ginkgo.Describe("MPIJob", func() {
ginkgo.BeforeEach(func() {
mpiJob.Spec.MPIReplicaSpecs[kubeflow.MPIReplicaTypeLauncher].Template.Spec.Containers = []corev1.Container{
{
Name: "launcher",
Image: openMPIImage,
Command: []string{"mpirun"},
Name: "launcher",
Image: openMPIImage,
ImagePullPolicy: corev1.PullNever,
Command: []string{"mpirun"},
Args: []string{
"-n",
"2",
Expand All @@ -96,8 +97,9 @@ var _ = ginkgo.Describe("MPIJob", func() {
}
mpiJob.Spec.MPIReplicaSpecs[kubeflow.MPIReplicaTypeWorker].Template.Spec.Containers = []corev1.Container{
{
Name: "worker",
Image: openMPIImage,
Name: "worker",
Image: openMPIImage,
ImagePullPolicy: corev1.PullNever,
},
}
})
Expand Down Expand Up @@ -190,9 +192,10 @@ var _ = ginkgo.Describe("MPIJob", func() {
mpiJob.Spec.MPIImplementation = kubeflow.MPIImplementationIntel
mpiJob.Spec.MPIReplicaSpecs[kubeflow.MPIReplicaTypeLauncher].Template.Spec.Containers = []corev1.Container{
{
Name: "launcher",
Image: intelMPIImage,
Command: []string{}, // uses entrypoint.
Name: "launcher",
Image: intelMPIImage,
ImagePullPolicy: corev1.PullNever,
Command: []string{}, // uses entrypoint.
Args: []string{
"mpirun",
"-n",
Expand All @@ -203,9 +206,10 @@ var _ = ginkgo.Describe("MPIJob", func() {
}
mpiJob.Spec.MPIReplicaSpecs[kubeflow.MPIReplicaTypeWorker].Template.Spec.Containers = []corev1.Container{
{
Name: "worker",
Image: intelMPIImage,
Command: []string{}, // uses entrypoint.
Name: "worker",
Image: intelMPIImage,
ImagePullPolicy: corev1.PullNever,
Command: []string{}, // uses entrypoint.
Args: []string{
"/usr/sbin/sshd",
"-De",
Expand Down

0 comments on commit 58f4191

Please sign in to comment.