-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep up with midstream #706
Conversation
eedb41a
to
67c3c8c
Compare
f450362
to
f490ecd
Compare
clients/ui/frontend/src/__tests__/cypress/cypress/pages/modelRegistry.ts
Outdated
Show resolved
Hide resolved
clients/ui/frontend/src/app/pages/modelRegistry/screens/ModelVersionDetails/const.ts
Show resolved
Hide resolved
...nd/src/app/pages/modelRegistry/screens/ModelVersionsArchive/ModelVersionsArchiveListView.tsx
Outdated
Show resolved
Hide resolved
...rontend/src/app/pages/modelRegistry/screens/RegisterModel/RegistrationCommonFormSections.tsx
Show resolved
Hide resolved
clients/ui/frontend/src/app/pages/modelRegistry/screens/RegisterModel/utils.ts
Outdated
Show resolved
Hide resolved
clients/ui/frontend/src/shared/components/DashboardDescriptionListGroup.tsx
Outdated
Show resolved
Hide resolved
clients/ui/frontend/src/shared/components/NotebookController.scss
Outdated
Show resolved
Hide resolved
clients/ui/frontend/src/shared/components/NotebookController.scss
Outdated
Show resolved
Hide resolved
3a19a27
to
ebd051e
Compare
ebd051e
to
93c067c
Compare
Signed-off-by: lucferbux <[email protected]>
93c067c
to
d88c29a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the code but tested locally in kind and it works great!
Nice job!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As Griffen did a thorough code review and we've both tested it. merging. /gtm |
/lgtm |
Description
This PR intends to update the functionality of MR by updating the codebase with latest Midstream changes.
There are some UI inconsistencies that we'll need to tweak cc @jenny-s51
Please take a look at all the pages in the review.
Screenshots
How Has This Been Tested?
Updated all testing, both unit and integration. Tested manually too.
Merge criteria:
DCO
check)If you have UI changes