-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp deployment files to get UI in one container #699
Revamp deployment files to get UI in one container #699
Conversation
6ca094d
to
a90a65d
Compare
a90a65d
to
708910e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to test. That was a lot of work nice job @lucferbux!
708910e
to
4639a1c
Compare
4639a1c
to
24d1e7f
Compare
67eaf19
to
6d6e9d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for local dev, local kind deployment, and kubeflow deployment. Nice work @lucferbux!
f4a991b
to
37958bd
Compare
Signed-off-by: lucferbux <[email protected]>
37958bd
to
2a81b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- per understanding this refactor from 2 images, 2 Pods to make BFF use separate from UI optionally,
- not moving to 1 Pod 2 containers as it would make it tricky to support option of BFF without UI
- and move to 1 Pod 1 image with both BFF and F/E, so to make option in the deployment to avoid/skip UI capability
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Griffin-Sullivan, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
Refactor the architecture to serve everything in the same container
How Has This Been Tested?
I need to test kubeflow integration first
For local kind cluster just run
make kind-deployment
and test that it's working.Merge criteria:
DCO
check)If you have UI changes