Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp deployment files to get UI in one container #699

Merged

Conversation

lucferbux
Copy link
Contributor

Description

Refactor the architecture to serve everything in the same container

How Has This Been Tested?

I need to test kubeflow integration first

For local kind cluster just run make kind-deployment and test that it's working.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@lucferbux lucferbux force-pushed the simplify-deployment-dockerfile branch 3 times, most recently from 6ca094d to a90a65d Compare January 14, 2025 01:43
@lucferbux lucferbux force-pushed the simplify-deployment-dockerfile branch from a90a65d to 708910e Compare January 14, 2025 11:52
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test. That was a lot of work nice job @lucferbux!

.github/workflows/build-and-push-ui-images.yml Outdated Show resolved Hide resolved
@lucferbux lucferbux force-pushed the simplify-deployment-dockerfile branch from 708910e to 4639a1c Compare January 14, 2025 20:48
@lucferbux lucferbux force-pushed the simplify-deployment-dockerfile branch from 4639a1c to 24d1e7f Compare January 14, 2025 22:29
@lucferbux
Copy link
Contributor Author

Ok so tested in these environments:

  • Local development
  • Build kind deployment (automated script)
  • Kubeflow deployment

We've removed docker-compose and improve documentation to display all the configurations. Also, I've tested github actions and its working just fine:
Screenshot 2025-01-15 at 00 24 34

cc @rareddy @tarilabs

@lucferbux lucferbux force-pushed the simplify-deployment-dockerfile branch 3 times, most recently from 67eaf19 to 6d6e9d7 Compare January 15, 2025 14:11
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for local dev, local kind deployment, and kubeflow deployment. Nice work @lucferbux!

clients/ui/README.md Show resolved Hide resolved
@lucferbux lucferbux force-pushed the simplify-deployment-dockerfile branch 2 times, most recently from f4a991b to 37958bd Compare January 15, 2025 20:41
@lucferbux lucferbux force-pushed the simplify-deployment-dockerfile branch from 37958bd to 2a81b1d Compare January 16, 2025 12:12
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me!

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • per understanding this refactor from 2 images, 2 Pods to make BFF use separate from UI optionally,
  • not moving to 1 Pod 2 containers as it would make it tricky to support option of BFF without UI
  • and move to 1 Pod 1 image with both BFF and F/E, so to make option in the deployment to avoid/skip UI capability

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Griffin-Sullivan, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Griffin-Sullivan
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 16, 2025
@google-oss-prow google-oss-prow bot merged commit 6a052c1 into kubeflow:main Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants