-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix GHA invocation of docker tag push script #30
fix GHA invocation of docker tag push script #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tarilabs , noticed just a typo
notified of failing DCO check here: https://kubeflow.slack.com/archives/C7REE0ETX/p1709722338099339
|
c5fbf3d
to
1b73fb2
Compare
1b73fb2
to
767da57
Compare
Co-authored-by: Andrea Lamparelli <[email protected]> Signed-off-by: Matteo Mortari <[email protected]>
767da57
to
6e59f5a
Compare
/lgtm 👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhirajsb, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
The goal of this PR is to fix 2 issues in the current GHA invocation:
VERSION
needed to be pass down to push the tagged layer (the layers and rolling tags are already pushed from the steps above, what needs to happen is GHA need to instruct the script to just-push the newly created tag)Description
With this change:
latest
andmain
tag are synced to the most recent image produced (except of release versions)latest-release
tag following similar GHA snippet laterHow Has This Been Tested?
Merge criteria: