Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GHA invocation of docker tag push script #30

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Mar 6, 2024

The goal of this PR is to fix 2 issues in the current GHA invocation:

  • VERSION needed to be pass down to push the tagged layer (the layers and rolling tags are already pushed from the steps above, what needs to happen is GHA need to instruct the script to just-push the newly created tag)

Description

With this change:

  • ensure latest and main tag are synced to the most recent image produced (except of release versions)
  • we can always introduce a latest-release tag following similar GHA snippet later

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarilabs , noticed just a typo

.github/workflows/build-and-push-image.yml Outdated Show resolved Hide resolved
@tarilabs
Copy link
Member Author

tarilabs commented Mar 6, 2024

notified of failing DCO check here: https://kubeflow.slack.com/archives/C7REE0ETX/p1709722338099339

DCO for GitHub suggestion being applied
Hi, Just thought of headsup to the KF community leaders, it seems to me some GitHub configuration is needed for those commits coming as GitHub Review suggestions, as allegedly they are the ones failing some automated DCO check.
Example: #30 (comment)
Thank you, hope this helps

@tarilabs tarilabs force-pushed the tarilabs-20240306-fixDockerTagPushScript branch from c5fbf3d to 1b73fb2 Compare March 7, 2024 08:44
@google-oss-prow google-oss-prow bot added size/XS and removed size/S labels Mar 7, 2024
@tarilabs tarilabs force-pushed the tarilabs-20240306-fixDockerTagPushScript branch from 1b73fb2 to 767da57 Compare March 7, 2024 08:49
Co-authored-by: Andrea Lamparelli <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs tarilabs force-pushed the tarilabs-20240306-fixDockerTagPushScript branch from 767da57 to 6e59f5a Compare March 7, 2024 08:50
@dhirajsb
Copy link
Contributor

dhirajsb commented Mar 7, 2024

/lgtm 👍

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhirajsb, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rareddy
Copy link
Contributor

rareddy commented Mar 7, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 7, 2024
@google-oss-prow google-oss-prow bot merged commit 3e93a2c into kubeflow:main Mar 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants