Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Add artifact & execution map to ListEvents endpoint #84

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 103 additions & 79 deletions api/service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions api/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ message ListEventsRequest {

message ListEventsResponse {
repeated ml_metadata.Event events = 1;
map<int64, ml_metadata.Artifact> artifacts = 2;
map<int64, ml_metadata.Execution> executions = 3;
}

service MetadataService {
Expand Down
12 changes: 12 additions & 0 deletions api/service.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,18 @@
"$ref": "#/definitions/ml_metadataEvent"
},
"collectionFormat": "multi"
},
"artifacts": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/ml_metadataArtifact"
}
},
"executions": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/ml_metadataExecution"
}
}
}
},
Expand Down
50 changes: 49 additions & 1 deletion service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,55 @@ func (s *Service) ListEvents(ctx context.Context, req *api.ListEventsRequest) (*
}
events, err = s.store.GetEventsByExecutionIDs([]mlmetadata.ExecutionID{mlmetadata.ExecutionID(id)})
}
artifacts, err := s.getArtifactsInEvents(events)
if err != nil {
return nil, fmt.Errorf("failed to get artifacts in events: %v", err)
}
executions, err := s.getExecutionsInEvents(events)
if err != nil {
return nil, fmt.Errorf("failed to get executions in events: %v", err)
}
return &api.ListEventsResponse{
Events: events,
Events: events,
Artifacts: artifacts,
Executions: executions,
}, err
}

func (s *Service) getArtifactsInEvents(events []*mlpb.Event) (map[int64]*mlpb.Artifact, error) {
results := make(map[int64]*mlpb.Artifact)
for _, e := range events {
id := e.GetArtifactId()
if _, exists := results[id]; exists {
zhenghuiwang marked this conversation as resolved.
Show resolved Hide resolved
continue
}
artifacts, err := s.store.GetArtifactsByID([]mlmetadata.ArtifactID{mlmetadata.ArtifactID(id)})
if err != nil {
return nil, err
}
if len(artifacts) != 1 {
return nil, fmt.Errorf("internal error: expecting single new Artifact id, got instead : %v", artifacts)
}
results[id] = artifacts[0]
}
return results, nil
}

func (s *Service) getExecutionsInEvents(events []*mlpb.Event) (map[int64]*mlpb.Execution, error) {
results := make(map[int64]*mlpb.Execution)
for _, e := range events {
id := e.GetExecutionId()
if _, exists := results[id]; exists {
continue
}
executions, err := s.store.GetExecutionsByID([]mlmetadata.ExecutionID{mlmetadata.ExecutionID(id)})
if err != nil {
return nil, err
}
if len(executions) != 1 {
return nil, fmt.Errorf("internal error: expecting single new execution id, got instead : %v", executions)
}
results[id] = executions[0]
}
return results, nil
}
Loading