Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes version 1.26 and set it to default for testing #2482

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

annajung
Copy link
Member

Which issue is resolved by this Pull Request:
Part of #2450

Description of your changes:

  • Move default KinD 1.25 to kind-cluster-1-25.yaml
  • Add support for Kubernetes 1.26 and set it to default for testing
  • Update the requirements.txt to run e2e with katib 0.15 and kfp 1.8.22

@annajung
Copy link
Member Author

cc @kimwnasptd

@kimwnasptd
Copy link
Member

@annajung I remember that we had to use the awk '!/well-defined/' command because of this bug in kustomize kubernetes-sigs/kustomize#5039.

Can we avoid these awk commands by instead using kustomize 5.0.1?

@annajung
Copy link
Member Author

I think we can upgrade to kustomize 5.0.3

I ran a few tests to compare results between kustomize 5 with hack vs. kustomize 5.0.3 without the hack and looks like output is the same. I'll make a PR to upgrade Kustomize and update this PR.

@annajung
Copy link
Member Author

This PR depends on kustomize 5.0.3 upgrade PR #2490, which fixes the kustomize 5 bug that makes the pipeline test fail.

Anna Jung (VMware) added 4 commits July 24, 2023 13:54
Signed-off-by: Anna Jung (VMware) <[email protected]>
Signed-off-by: Anna Jung (VMware) <[email protected]>
@annajung annajung force-pushed the update-kubernetes branch from b88a795 to 3a4285e Compare July 24, 2023 17:56
@kimwnasptd
Copy link
Member

All tests passed, nice one!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit da3318c into kubeflow:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants