Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oidc-authservice image tag #1839

Closed

Conversation

davidspek
Copy link
Contributor

While going through the image tags for the Kubeflow deployment I noticed that the image tag for the OIDC-authservice is from December 2019. Looking at the registry there are some images that were created 12 days ago with a -dirty suffix, the image tag in this PR is the newest with this suffix.

@yanniszark I'm not sure what has changed with the OIDC-authservice, since this is an Arrikto project. Should this be updated? Do you know the difference between the regular and the -dirty image tags for the OIDC-authservice? I assume the newer versions contain bug/security fixes that Kubeflow distributions would then want to use.

@google-cla google-cla bot added the cla: yes label Apr 13, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidSpek
To complete the pull request process, please assign stefanofioravanzo after the PR has been reviewed.
You can assign the PR to them by writing /assign @stefanofioravanzo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanniszark
Copy link
Contributor

@davidspek unfortunately it is not possible to do this yet. Please see:
#1714 (comment)

@davidspek
Copy link
Contributor Author

@yanniszark Thanks for informing me. I figured there was likely a reason this was not done yet. Also, sorry for creating the duplicate PR. I doubt I will have the time for updating the Central Dashboard to be able to use newer images of the OIDC authservice, but I'll keep it in mind if I don't feel like working on other stuff one day.

@stale
Copy link

stale bot commented Jul 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 20, 2021

This issue has been closed due to inactivity.

@stale stale bot closed this Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants