Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken v1.3 OIDC auth manifest #1805

Closed
wants to merge 1 commit into from
Closed

Fixes broken v1.3 OIDC auth manifest #1805

wants to merge 1 commit into from

Conversation

berndverst
Copy link
Member

@berndverst berndverst commented Apr 7, 2021

v1.3 OIDC auth manifests are broken

Example installation of Kubeflow v1.3 using kustomize provided by @yanniszark does not succeed as a result

Which issue is resolved by this Pull Request:
Corrects #1735

Description of your changes:
Current OIDC Auth Service manifests are not valid. This addresses the syntax error.

Current error:

kustomize build --load_restrictor=none common/oidc-authservice/base
Error: json: unknown field "env"

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

v1.3 OIDC auth manifests are broken

Example installation of Kubeflow v1.3 using kustomize provided by @yanniszark does not succeed as a result
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: berndverst
To complete the pull request process, please assign vkoukis after the PR has been reviewed.
You can assign the PR to them by writing /assign @vkoukis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@berndverst
Copy link
Member Author

@yanniszark this will need to be cherry-picked into the v1.3-branch FYI

@davidspek
Copy link
Contributor

Duplicate of #1789

@yanniszark
Copy link
Contributor

@berndverst thanks for the PR! In general, I'm in favor of using the newer envs field, however I don't think:

Example installation of Kubeflow v1.3 using kustomize provided by @yanniszark does not succeed as a result

is accurate. Kustomize 3.2.0, which is explicitly provided by the installation guide, builds the installation successfully.
Since @davidspek has already opened #1789, I'm closing this as a duplicate and continuing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants