Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to Intel's tutorial #652

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Conversation

raddaoui
Copy link
Contributor

@raddaoui raddaoui commented Apr 12, 2018

Closes #612


This change is Reviewable

Copy link

@inc0 inc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@raddaoui
Copy link
Contributor Author

/test kubeflow-presubmit

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

The tutorial LGTM but I am not sure if we should put it in this section.

@pdmack
Copy link
Member

pdmack commented Apr 19, 2018

@gaocegege good enough for now or relocate?

@gaocegege
Copy link
Member

/lgtm

@pdmack It works for me. I approved it since no one respond 😄

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, inc0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdmack
Copy link
Member

pdmack commented Apr 19, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 158b74c into kubeflow:master Apr 19, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* Adding grid e2e test to presubmit

* Adding extra checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants