Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though model server itself can be the entry point itself but then run with PID 1 would make the server not responding to SIGINT or SIGTERM
which is problematic during k8s rolling up new version
Using Tini has several benefits:
which can (over time!) starve your entire system for PIDs (and make it
unusable).
in your Docker image. For example, with Tini,
SIGTERM
properly terminatesyour process even if you didn't explicitly install a signal handler for it.
will work with Tini without any changes.
This change is