Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grant KF user SA CMLE admin permission #2013

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 29, 2018

This change is Reviewable

@abhi-g
Copy link
Member

abhi-g commented Nov 29, 2018

/cc @kunmingg

@IronPan
Copy link
Member Author

IronPan commented Nov 29, 2018

fix #2012

@IronPan
Copy link
Member Author

IronPan commented Nov 29, 2018

/assign @kunmingg @jlewi

@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e7fb346 into kubeflow:master Nov 29, 2018
IronPan added a commit to IronPan/kubeflow that referenced this pull request Dec 4, 2018
Pipeline needs the CMLE and dataproc editor permission to run the xgboost dataproc samples
For dataproc details, see
https://github.com/kubeflow/pipelines/tree/master/components/dataproc
For CMLE, see similar PR
kubeflow#2013
IronPan added a commit to IronPan/kubeflow that referenced this pull request Dec 6, 2018
k8s-ci-robot pushed a commit that referenced this pull request Dec 6, 2018
* initial change - add pipeline entry to kubeflow registry (#1973)

* add pipeline entry

* use camel case for params

* formatting

* format

* fix

* remove spartakus

* merge 01f4bc2

* merge b5bfe47

* grant KF user SA CMLE admin permission (#2013)

* Activate CMLE during one-click deployment (#2017)

* merge 14ff472

* add permission to get pod's log (#2037)

Pipeline component needs the permission to  get tf serving pod log
https://github.com/kubeflow/pipelines/blob/master/components/kubeflow/deployer/src/deploy.sh#L202

* Add roles/dataproc.editor for kubeflow user account (#2035)

Pipeline needs the dataproc editor permission to run the xgboost dataproc samples
For details, see
https://github.com/kubeflow/pipelines/tree/master/components/dataproc

* Update Pipeline version to v0.1.3 (#2045)

* merge 21ff6ce

* resolve conflict

* Update kf_app.yaml

* add central dashboard

* merge
k8s-ci-robot pushed a commit that referenced this pull request Dec 21, 2018
* initial change - add pipeline entry to kubeflow registry (#1973)

* add pipeline entry

* use camel case for params

* formatting

* format

* fix

* remove spartakus

* merge 01f4bc2

* merge b5bfe47

* grant KF user SA CMLE admin permission (#2013)

* Activate CMLE during one-click deployment (#2017)

* merge 14ff472

* add permission to get pod's log (#2037)

Pipeline component needs the permission to  get tf serving pod log
https://github.com/kubeflow/pipelines/blob/master/components/kubeflow/deployer/src/deploy.sh#L202

* Add roles/dataproc.editor for kubeflow user account (#2035)

Pipeline needs the dataproc editor permission to run the xgboost dataproc samples
For details, see
https://github.com/kubeflow/pipelines/tree/master/components/dataproc

* Update Pipeline version to v0.1.3 (#2045)

* merge 21ff6ce

* resolve conflict

* Update kf_app.yaml

* add central dashboard

* merge

* Add job to load pipeline samples (#2071)

* Add job to load pipeline samples

Adding a job meets the requirement of 
- Load samples once when pipeline is deployed
- Not run job again during kf upgrade
- If loading samples failed, not blocking api server from start

* format

* update pipeline version (#2151)

* update pipeline version

* Update Dockerfile
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* Create kubeflow-edit-seldon.yaml

* Update kustomization.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants