Create a script to update a ksonnet app to the latest Kubeflow package #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The script removes the existing registry named kubeflow and any packages installed from that registry * It then readds Kubeflow using the supplied URL and reinstalls any packages. * Related to: kubeflow/website#57 * Based on the script in ksonnet/ksonnet#237
|
Looks like a test flake |
|
/assign @kunmingg |
kunmingg
reviewed
Jul 6, 2018
scripts/upgrade_ks_app.py
Outdated
| logging.info("Skipping registry %s", name) | ||
| continue | ||
| logging.info("Adding registry %s point at %s", name, registry_url) | ||
| subprocess.call(['ks', 'registry', 'add', name, registry_url]) |
There was a problem hiding this comment.
We need to either delete old registry info from app.yaml or use a new name like kubeflow-0.2.0.
Otherwise ks will complain when add new version registry with same name.
the registry being upgraded; and only delete the packages in that registry.
|
@kunmingg PTAL. We were deleting entries in app.yaml but there were bugs in the logic; we were deleting all entries and not just the registry being upgraded. |
jlewi
added a commit
to jlewi/testing
that referenced
this pull request
Jul 7, 2018
* Don't delete and recreate the ksonnet app. * Use the new upgrade script in kubeflow/kubeflow#1100 * Move creation of secrets into a separate script; there's no reason to recreate them just to update the app. * Add a bunch of fixes in redeploy_app.sh to deal with various issues in the way ks apply works; see comments in code for links to the issues.
jlewi
added a commit
to jlewi/testing
that referenced
this pull request
Jul 9, 2018
* Don't delete and recreate the ksonnet app. * Use the new upgrade script in kubeflow/kubeflow#1100 * Move creation of secrets into a separate script; there's no reason to recreate them just to update the app. * Add a bunch of fixes in redeploy_app.sh to deal with various issues in the way ks apply works; see comments in code for links to the issues. * Update the docs.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
to kubeflow/testing
that referenced
this pull request
Jul 10, 2018
* Don't delete and recreate the ksonnet app. * Use the new upgrade script in kubeflow/kubeflow#1100 * Move creation of secrets into a separate script; there's no reason to recreate them just to update the app. * Add a bunch of fixes in redeploy_app.sh to deal with various issues in the way ks apply works; see comments in code for links to the issues. * Update the docs.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
kubeflow#1100) * Create a script to update a ksonnet app to the latest Kubeflow package * The script removes the existing registry named kubeflow and any packages installed from that registry * It then readds Kubeflow using the supplied URL and reinstalls any packages. * Related to: kubeflow/website#57 * Based on the script in ksonnet/ksonnet#237 * * Only delete the registry entry in app.yaml corresponding to the registry being upgraded; and only delete the packages in that registry.
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
* v1.0.2 manifests * fix version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is