Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate the use of taskSpec.script #992

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Jul 7, 2022

Which issue is resolved by this Pull Request:
Resolves #989

Description of your changes:

when using script, it generates an init container to process the script.
we'd like to avoid the init container in pipelinerun.
remove script and use command and arg instead.

Signed-off-by: Yihong Wang [email protected]

Checklist:

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

when using script, it generates an init container to process the script.
we'd like to avoid the init container in pipelinerun.
remove `script` and use `command` and `arg` instead.

Signed-off-by: Yihong Wang <[email protected]>
@Tomcli
Copy link
Member

Tomcli commented Jul 8, 2022

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 8, 2022
@google-oss-prow google-oss-prow bot merged commit 9339454 into kubeflow:master Jul 8, 2022
@yhwang yhwang deleted the remove-task-script branch July 8, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert big data passing from Tekton script to Tekton args + commands
2 participants