-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): Verify binary data in step copy-results-artifacts. Fixes #984 #985
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @maxdebayser, can your run |
/lgtm |
@Tomcli , now when I visit https://cla.developers.google.com/ it says I'm covered by Google Corporate CLA. Is that all or do I have to do something more? |
@maxdebayser based on https://github.com/kubeflow/kfp-tekton/pull/985/checks?check_run_id=7219006673 |
@Tomcli I've verified that my IBM e-mail address is set in my commits. I've also added my IBM e-mail as a secondary to may github.com account. And now I've also clicked on "New Contributors: Update this check after signing the CLA by clicking [here]" link in the CLA check message. Apparently it's passing now. |
thanks @maxdebayser |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxdebayser, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue is resolved by this Pull Request:
Resolves #984
Description of your changes:
Add a verification to copy-results-artifacts to prevent small binary files from being copied. The presence of unprintable characters in the PipelineRun status breaks the
UpdateRun
function inrun_store.go
The verification with awk is compatible with the busybox container.
Environment tested:
python --version
): 3.8tkn version
): 1.5kubectl version
): v1.23.5/etc/os-release
): Fedora 35