Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelineloop): Add param with empty space test #970

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Jun 4, 2022

Which issue is resolved by this Pull Request:
Resolves #957

Description of your changes:
Unit test for PR #961 and #958

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Jun 4, 2022

cc @Udiknedormin

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, Udiknedormin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ScrapCodes
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 6, 2022
@google-oss-prow google-oss-prow bot merged commit 58e0297 into kubeflow:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(tekton-catalog) PipelineLoop: trims spaces from first and last element
3 participants