Store the uploaded pipeline as original yaml format #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
|
/unhold |
|
@yhwang e2e test passed here: https://cloud.ibm.com/devops/pipelines/tekton/f85a45d2-36fc-45fb-a449-b01c13cf5191/runs/828da46b-99e8-4245-96ec-8dc593d1d4ee/test/run-go-unittests?env_id=ibm:yp:us-south This should handle the v1 json issue introduced in kfp 1.8.0. I think the ultimate solution for this is to update the ui to render json since right now the ui only can do V2 IR json and yaml files |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli, yhwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wzhanw
pushed a commit
to wzhanw/kfp-tekton
that referenced
this pull request
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Store the uploaded pipeline as original yaml format. Since kfp 1.8, the uploaded file are loaded into json which break the V1 api of returning the file in yaml format. The V2 yaml support is still in process, so we want to revert the upload file back to yaml for the kubeflow 1.6 release since the v1 ui cannot render v1 json as code blocks.
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist: