Loop ranges should handle from = to, and generate one iteration. #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScrapCodes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tomcli
reviewed
May 16, 2022
| @@ -892,6 +892,11 @@ func computeIterations(run *v1alpha1.Run, tls *pipelineloopv1alpha1.PipelineLoop | |||
| } | |||
| } | |||
| } | |||
| if from == to && to == 0 && step != 0 { | |||
There was a problem hiding this comment.
I think the use case is when from == to, then the iteration is equals to 1. to doesn't have to be 0.
Another edge case could be that to - from < step if step > 0 and to - from > step if step < 0, then the iteration is also 1.
ScrapCodes
commented
May 16, 2022
tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun/pipelinelooprun_test.go
Outdated
Show resolved
Hide resolved
ScrapCodes
changed the title
|
thanks @ScrapCodes , overall it looks good to me. just one small question for the unit test above. |
|
thanks @ScrapCodes |
wzhanw
pushed a commit
to wzhanw/kfp-tekton
that referenced
this pull request
May 20, 2022
…eflow#941) * Loop ranges should handle start = 0 and end = 0, should generate one iteration. * When from = to, then generate one iteration. emulating how enumerate works. * Fixed edge cases. * if from and to are unset, we should not pick defaults either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #935
Description of your changes:
Where start = 0 and end = 0, generate one iteration.
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist: