Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for pipelineloop-break-operation task final status #936

Merged
merged 1 commit into from
May 12, 2022

Conversation

wzhanw
Copy link
Contributor

@wzhanw wzhanw commented May 11, 2022

Wait for pipelineloop-break-operation task final status before breaking the loop.

Which issue is resolved by this Pull Request:
Resolves #
#800 (comment)

Description of your changes:
wait until the break operation task is done, then cancel the looprun and break the loop.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member

Tomcli commented May 11, 2022

@wzhanw Will there be a rare case when the custom task is not able to complete, the pipeline will just not break in this case? @ScrapCodes I remember you were trying to do something like this at some point, do you remember what are the challenges you had?

@yhwang
Copy link
Member

yhwang commented May 11, 2022

is it possible to have a test case to verify this?

@wzhanw
Copy link
Contributor Author

wzhanw commented May 12, 2022

Hi @Tomcli, We have already hit such an issue during the test. but it is not easy to reproduce later. in our case, the break operation task is a custom run that does some calculations and store result in Redis.

@Tomcli
Copy link
Member

Tomcli commented May 12, 2022

@wzhanw I think your approach make sense. I just also want to get @ScrapCodes 's feedbacks since he was trying the other approach before to force the break task to be completed after breaking the loop.

@ScrapCodes
Copy link
Contributor

Since we cannot update directly the status of a custom task not owned by the current controller, this seems fine to me.
/lgtm

@Tomcli
Copy link
Member

Tomcli commented May 12, 2022

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, wzhanw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 425d4be into kubeflow:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants