wait for pipelineloop-break-operation task final status #936
Conversation
|
@wzhanw Will there be a rare case when the custom task is not able to complete, the pipeline will just not break in this case? @ScrapCodes I remember you were trying to do something like this at some point, do you remember what are the challenges you had? |
|
is it possible to have a test case to verify this? |
|
Hi @Tomcli, We have already hit such an issue during the test. but it is not easy to reproduce later. in our case, the break operation task is a custom run that does some calculations and store result in Redis. |
|
@wzhanw I think your approach make sense. I just also want to get @ScrapCodes 's feedbacks since he was trying the other approach before to force the break task to be completed after breaking the loop. |
|
Since we cannot update directly the status of a custom task not owned by the current controller, this seems fine to me. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli, wzhanw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wait for pipelineloop-break-operation task final status before breaking the loop.
Which issue is resolved by this Pull Request:
Resolves #
#800 (comment)
Description of your changes:
wait until the break operation task is done, then cancel the looprun and break the loop.
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist: