Fix multiple nested condition in loops issue #928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #924
Description of your changes:
In Tekton, we don't put our condition dag as a sub graph because it will forbidden task level dependencies as this is a limitation on Argo. Therefore, we need some logics to traverse all the ops inside the condition graph to figure out all the nested condition and ops that have to stay inside the loop dag.
Environment tested:
python --version
):tkn version
):kubectl version
):/etc/os-release
):Checklist: