pass down the podTemplate and serviceAccount from run to loopSpec #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tomcli Could you please review this PR? I think our use case is valid. |
|
Thanks @wzhanw for the PR. Let me run our internal CI pipelines to make sure it didn't break our current behaviors. The feature looks good to me |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli, wzhanw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
For our use case, we don't set
podTemplateandserviceAccountin the loopSpec, we only set them for the parent pipelinerun. The run created by Tekton controller will inherit the above two fields from the pipelinerun.But the loop controller doesn't pass the above two fields to pipelineLoopSpec.
Description of your changes:
get
podTemplateandserviceAccountfromrunand set them to pipelineLoopSpec if they are not configured.Environment tested:
All unit tests passed.