Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current iteration item to the PipelineLoopPipelineRunStatus #894

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

wzhanw
Copy link
Contributor

@wzhanw wzhanw commented Mar 25, 2022

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
The current PipelineLoopPipelineRunStatus only has the Iteration which is an integer value, sometimes it is meaningless for the user. We should have IterationItem in the status as well.
Environment tested:
Unit test passed.

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for also fix the cache pkg

@Tomcli
Copy link
Member

Tomcli commented Mar 25, 2022

Thanks @wzhanw, e2e test passed for this PR
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, wzhanw, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a7f6c0a into kubeflow:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants