fix: objectstore refactoring #887
Conversation
|
thanks @ScrapCodes , the e2e test passed this time |
|
@yhwang any comment? |
tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun/controller.go
Show resolved
Hide resolved
|
this is still WIP and toolchain pipeline passed. it's good to me now. |
ScrapCodes
changed the title
| } | ||
| } | ||
| if err == nil && enabled { | ||
| logger.Info("Loading object store logger...") |
There was a problem hiding this comment.
my apology. when I mentioned merging the condition checks, I didn't mean just combining them together. I know from here below you still need to check if the objectStoreLogger is properly loaded or not, right? I don't know the code below can run properly without a valid objectStroeLogger.
ScrapCodes
force-pushed
the
objectstore-refactor-fix
branch
from
729a6c3
to
12a151d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScrapCodes, yhwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist: