Add tekton loop dsl extension skeleton #799
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @yhwang |
| BreakOp_template = components.load_component_from_text(BreakOp_yaml) | ||
| BreakOp = BreakOp_template() | ||
| return BreakOp | ||
|
|
There was a problem hiding this comment.
To be honest I did not follow how the break happens here. Seems it's just a normal task?
There was a problem hiding this comment.
Yes, right now the pipeline loop break only works when the last-loop-task is skipped. However, the proposed Break() DSL is to break when the condition is met. So I opened #800 to add a new break features to break when the Break() task is being executed.
There was a problem hiding this comment.
Sorry I just overlooked that issue. Then it makes sense. Thanks for all your explanation.
|
/lgtm |
Which issue is resolved by this Pull Request:
Related #791
Description of your changes:
Add SDK skeleton for Tekton specific DSL extensions.
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist: