Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelineloop): Support workspaces for pipelineLoop. #787

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

ScrapCodes
Copy link
Contributor

Which issue is resolved by this Pull Request:
Resolves #786

Description of your changes:
Added support for supporting workspaces in pipelineLoopSpec.
Added tests and examples.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member

Tomcli commented Nov 24, 2021

thanks @ScrapCodes for the quick PR
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScrapCodes, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e0e60bd into kubeflow:master Nov 24, 2021
wzhanw pushed a commit to wzhanw/kfp-tekton that referenced this pull request Nov 25, 2021
* Support workspaces for pipelineLoop.

* fix doc link test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelineloop controller cannot define workspaces.
2 participants